-
Notifications
You must be signed in to change notification settings - Fork 0
clay/geoviz updates #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
i'm getting some typescript errors from
|
could you run these commands to adjust formatting and update the lock file?
|
const API_URL = | ||
process.env["WHEROBOTS_API_URL"] || "https://api.cloud.wherobots.com"; | ||
|
||
const PROTOCOL_VERSION = "1.0.0"; | ||
const OS_TYPE = `${process.platform};${process.arch}`; | ||
const NODE_VERSION = process.version; | ||
const USER_AGENT = `${packageJson?.name}/${packageJson?.version} os/${OS_TYPE} node/${NODE_VERSION}"`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd rather not lose the package version from the user agent string. is there a way we can inject this as a build-time variable?
package.json
Outdated
"description": "TypeScript SDK for Wherobots DB", | ||
"license": "Apache-2.0", | ||
"main": "dist/src/index.js", | ||
"type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is "type": "module"
necessary? it breaks the running of the example scripts (e.g. node -r @swc-node/register examples/connectionWithDefaults.ts
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to use it to be esm compatible for one of the packages. Will see if I can remove it. Also, I recommend we use npx for this so I have now replaced the command with npx tsx examples/connectionWithDefaults.ts (tsx runs ts files)
Uses browser/nodejs compatible packages, switches to using query param auth on the browser