.lean() with post-hook of .find and .findOne #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doguhanokumus
force-pushed
the
lean-for-post-find-findone
branch
from
7a16baa to
40cdb16
Compare
|
This looks good but we definitely need a few tests to verify that the feature works as expected. If you can add them, I'd be happy to merge. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again 😊
I also had to use .lean functionality in our business as we have over 250 queries running throughout our projects and it would take much more time to replace them all.
So I've added the workaround I came up with, mapping after the document(s) are returned with the post hook for find and findOne.
This seems to be working fine with our tests, I hope you can have time to verify and merge soon.
Doguhan