Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "inner invoke" use "remove an event listener" #758

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make "inner invoke" use "remove an event listener" #758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2d6c60
Make "inner invoke" use "remove an event listener"
oliverdunk May 6, 2019
d208656
Justify abstraction use and update Acknowledgments
oliverdunk May 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dom.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,8 +1568,8 @@ run these steps:
<a for="event listener">capture</a> is true, then <a for=iteration>continue</a>.

<li><p>If <var>listener</var>'s <a for="event listener">once</a> is true, then
<a for=list>remove</a> <var>listener</var> from <var>event</var>'s {{Event/currentTarget}}
attribute value's <a for=EventTarget>event listener list</a>.
<a>remove an event listener</a> with the <var>event</var>'s {{Event/currentTarget}}
and <var>listener</var></a>.
<!-- Do this before invocation to avoid reentrancy issues. No need to set removed to true since
each listener in listeners is run once anyway. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword the second sentence here to say something like "Note that there is no need to set removed to true since listener is run once, but it is done here to share an abstraction."


Expand Down