Revert "Trusted Types integration for "converting nodes into a node"" #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 720a4fc. These changes aren't needed given the current protection model used for script elements.
lukewarlow
added a commit
to lukewarlow/WebKit
that referenced
this pull request
Jul 22, 2024
https://bugs.webkit.org/show_bug.cgi?id=276881 Reviewed by NOBODY (OOPS!). The enforcement of Trusted Types in various node manipulation APIs in DOM was based on a previous model for protecting script elements. This patch removes it as its not needed. See whatwg/dom#1299 and w3c/trusted-types#537 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments.html. * Source/WebCore/dom/ChildNode.idl: * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::append): (WebCore::ContainerNode::prepend): (WebCore::ContainerNode::replaceChildren): * Source/WebCore/dom/ContainerNode.h: * Source/WebCore/dom/Node.cpp: (WebCore::nodeSetPreTransformedFromNodeOrStringVector): (WebCore::Node::convertNodesOrStringsIntoNode): (WebCore::Node::convertNodesOrStringsIntoNodeVector): (WebCore::Node::before): (WebCore::Node::after): (WebCore::Node::replaceWith): (WebCore::nodeSetPreTransformedFromNodeOrStringOrTrustedScriptVector): Deleted. (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNode): Deleted. (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNodeVector): Deleted. * Source/WebCore/dom/Node.h: * Source/WebCore/dom/ParentNode.idl: * Source/WebCore/dom/TrustedType.cpp: (WebCore::processNodeOrStringAsTrustedType): Deleted. * Source/WebCore/dom/TrustedType.h:
webkit-commit-queue
pushed a commit
to lukewarlow/WebKit
that referenced
this pull request
Jul 24, 2024
https://bugs.webkit.org/show_bug.cgi?id=276881 Reviewed by Ryosuke Niwa. The enforcement of Trusted Types in various node manipulation APIs in DOM was based on a previous model for protecting script elements. This patch removes it as its not needed. See whatwg/dom#1299 and w3c/trusted-types#537 * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/Node-multiple-arguments-tt-enforced.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/block-Node-multiple-arguments.html. * Source/WebCore/dom/ChildNode.idl: * Source/WebCore/dom/ContainerNode.cpp: (WebCore::ContainerNode::append): (WebCore::ContainerNode::prepend): (WebCore::ContainerNode::replaceChildren): * Source/WebCore/dom/ContainerNode.h: * Source/WebCore/dom/Node.cpp: (WebCore::nodeSetPreTransformedFromNodeOrStringVector): (WebCore::Node::convertNodesOrStringsIntoNode): (WebCore::Node::convertNodesOrStringsIntoNodeVector): (WebCore::Node::before): (WebCore::Node::after): (WebCore::Node::replaceWith): (WebCore::nodeSetPreTransformedFromNodeOrStringOrTrustedScriptVector): Deleted. (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNode): Deleted. (WebCore::Node::convertNodesOrStringsOrTrustedScriptsIntoNodeVector): Deleted. * Source/WebCore/dom/Node.h: * Source/WebCore/dom/ParentNode.idl: * Source/WebCore/dom/TrustedType.cpp: (WebCore::processNodeOrStringAsTrustedType): Deleted. * Source/WebCore/dom/TrustedType.h: Canonical link: https://commits.webkit.org/281285@main
annevk
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 720a4fc.
These changes aren't needed given the current protection model used for script elements. See w3c/trusted-types#537
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff