[Refactor]: 패키지 분리 #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertImKr
commented
Mar 7, 2025
Comment on lines
+12
to
+19
| interface UrlShortenService { | ||
|
|
||
| fun getOriginUrl(request: ShortenUrlSearchRequest): OriginUrlResponse | ||
| fun saveShortenUrl(request: ShortenUrlCreateRequest): ShortenedUrlResponse | ||
| } | ||
|
|
||
| @Service | ||
| class DefaultUrlShortenService(private val shortenedUrlRepository: ShortenedUrlRepository) : UrlShortenService { |
There was a problem hiding this comment.
Service 구현체를 한 파일에서 관리하도록 변경했어요.
There was a problem hiding this comment.
구현체의 종류가 늘어나면 어떻게 하실 생각인가요?
| @@ -1,4 +1,4 @@ | |||
| package community.whatever.onembackendkotlin | |||
| package community.whatever.onembackendkotlin.common.dto | |||
There was a problem hiding this comment.
Dto를 매 계층마다 관리할 수 있지만 복잡한 프로젝트가 아니라서 코드의 격리보다 코드의 복잡성 증가를 방지하기 위해 Common 패키지에 Dto를 모아두었어요.
There was a problem hiding this comment.
Hyune-c
approved these changes
Mar 7, 2025
Comment on lines
+12
to
+19
| interface UrlShortenService { | ||
|
|
||
| fun getOriginUrl(request: ShortenUrlSearchRequest): OriginUrlResponse | ||
| fun saveShortenUrl(request: ShortenUrlCreateRequest): ShortenedUrlResponse | ||
| } | ||
|
|
||
| @Service | ||
| class DefaultUrlShortenService(private val shortenedUrlRepository: ShortenedUrlRepository) : UrlShortenService { |
There was a problem hiding this comment.
구현체의 종류가 늘어나면 어떻게 하실 생각인가요?
| if (shortenedUrlRepository.existsByOriginUrl(originUrl)) { | ||
| return ShortenedUrlResponse(shortenedUrlRepository.findByOriginUrl(originUrl)!!.id!!) | ||
| } | ||
| return ShortenedUrlResponse(shortenedUrlRepository.save(ShortenedUrl(originUrl)).id!!) |
| @@ -1,4 +1,4 @@ | |||
| package community.whatever.onembackendkotlin | |||
| package community.whatever.onembackendkotlin.common.dto | |||
There was a problem hiding this comment.
| @@ -1,4 +1,4 @@ | |||
| package community.whatever.onembackendkotlin | |||
| package community.whatever.onembackendkotlin.common.exception | |||
|
|
|||
| const val URL_NOT_FOUND_MESSAGE = "해당 키에 대한 URL이 존재하지 않습니다." | |||
There was a problem hiding this comment.
exception 안에 있고 밖에 있고의 차이가 무엇일까요?
nit저는 top-level 에 무엇이 있는 것을 선호하지 않지 않습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정사항