[Refactor] JSON으로 전환 #96
Open
+78
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyune-c
approved these changes
Mar 6, 2025
| } | ||
| return shortenedUrlRepository.save(ShortenedUrl(originUrl)).id!! | ||
| return ShortenedUrlResponse(shortenedUrlRepository.save(ShortenedUrl(originUrl)).id!!) | ||
| } |
There was a problem hiding this comment.
nit 비즈니스 레이어에 프레젠테이션 레이어의 객체가 있는 것은 선호하지 않습니다.
| .expectBody(String::class.java) | ||
| .isEqualTo(originUrl) | ||
| .expectBody(OriginUrlResponse::class.java) | ||
| .isEqualTo(OriginUrlResponse(originUrl)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정 사항