Skip to content

Commit

Permalink
fix(whatislove-dev): add fieldset element to theme switcher wd-586 (#592
Browse files Browse the repository at this point in the history
)

* fix(whatislove-dev): edit canonical on all pages wd-586

* fix(whatislove-dev): add fieldset element to theme switcher wd-586
  • Loading branch information
what1s1ove authored Jun 10, 2024
1 parent 7c60413 commit e4d825d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
6 changes: 3 additions & 3 deletions apps/whatislove-dev/src/includes/settings.njk
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{% macro settings(className) %}
<section class="{{ className }} settings settings--theme">
<h2 class="settings__title visually-hidden">Theme switcher</h2>
<fieldset class="{{ className }} settings settings--theme">
<legend class="settings__title visually-hidden">Theme switcher</legend>
<input class="settings__theme-control" type="radio" name="theme" value="light" aria-label="Light" />
<input class="settings__theme-control" type="radio" name="theme" value="auto" aria-label="Auto" checked />
<input class="settings__theme-control" type="radio" name="theme" value="dark" aria-label="Dark" />
</section>
</fieldset>
{% endmacro %}
2 changes: 1 addition & 1 deletion apps/whatislove-dev/src/layouts/page.njk
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<link rel="apple-touch-icon" href="/images/favicons/180.png" />
<link rel="manifest" href="/manifest.json" />

<link rel="canonical" href="{{ global.domain }}" />
<link rel="canonical" href="{{ global.domain + page.url }}" />
<link rel="authorization_endpoint" href="https://indieauth.com/auth" />

<meta name="description" content="{{ pageDescription }}" />
Expand Down
2 changes: 2 additions & 0 deletions apps/whatislove-dev/src/styles/blocks/settings.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
align-items: center;
padding-block: 8px;
padding-inline: 10px;
margin: 0;
background-color: hsl(var(--color-page-background-highlight));
border: 0;
border-radius: 5px;
}

Expand Down

0 comments on commit e4d825d

Please sign in to comment.