Replace ingredient search function #1724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the existing filter mechanisms from django-filter
rolandgeider
force-pushed
the
feature/ingredient-search
branch
from
e138bee to
6887068
Compare
rolandgeider
added a commit
to wger-project/react
that referenced
this pull request
Jul 12, 2024
Note that this is a workaround, ideally we would properly support the new results and not just convert them. See wger-project/wger#1724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now uses the existing filter mechanisms from django-filter.
Usage:
api/v2/ingredient/search?term=foobecomesapi/v2/ingredient[info]/?name__search=foo&language__codes=enOther changes:
&language=*to disable this filter. Now this behaviour can be controlled by passing the appropriate language parameter or not.&limit=xyz&source_name=USDA