-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Languages sync patch via command (docker issues #78) #1693
Open
Victorivus
wants to merge
11
commits into
wger-project:master
Choose a base branch
from
Victorivus:Victorivus-languages-sync-patch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Languages sync patch via command (docker issues #78) #1693
Victorivus
wants to merge
11
commits into
wger-project:master
from
Victorivus:Victorivus-languages-sync-patch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests weren't passing because it was Postgre specific. Now they do work (https://github.com/Victorivus/wger/pull/1/checks). Changes made:
Test in "production" was done as so:
|
@rolandgeider just to let you know that I fixed the test pipeline if you want to rerun it |
haven't forgotten you, will take a look this weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
sync_core_languages
which fixes the error of languages having different IDs if we deleted some and made an exercise sync after (DETAIL: Key (language_id)=(4) is not present in table "core_language". docker#78)Please check that the PR fulfills these requirements
Other questions
If you encounter the languages problem (e.g. wger-project/docker#78), just run:
manage.py sync_core_languages
or
docker compose exec web python3 manage.py sync_core_languages