Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#12 #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

#12 #13

wants to merge 3 commits into from

Conversation

Answeror
Copy link

  • Make static lib on windows platform, because no symbol exported.
  • Use boost::math::isnan for portability.
  • Change vector construction code to pass assert in vector operator [].
  • Move the backtracking part into dp algorithm, to reduce memory use. (Just some adhoc changes. Redundant variables not removed.)

@Answeror
make lib static on windows (no export symbol); use boost::math::isnan…
68690aa 
… for portablity
@Answeror
runnable on windows; change vector initialization in parts.hpp to pas…
65001f6 
…s assert in debug mode; merge min and argmin to reduce memory use; too many candidates detected
@Answeror
add msvc check
0b5815f
@vrabaud
Copy link
Member

vrabaud commented Mar 28, 2013

usually, just have one pull request per independent feature, otherwise it's tough to track. But thx a lot !
Concerning the NaN check, can you please use cvIsNaN (we're trying to only use Boost for non-core parts so that we can integrate this code in OpenCV).
@hbristow , can you please review the memory optimization ? Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Answeror @vrabaud