ssh doc addition, and remove compiler warning #6168
Conversation
term/src/screen.rs
Outdated
| if scroll_region.start != 0 || scroll_region.end as usize != self.physical_rows { | ||
| if scroll_region.start != 0 | ||
| || scroll_region.end as usize != self.physical_rows | ||
| || !self.allow_scrollback |
There was a problem hiding this comment.
I'm not sure about this change; it implies that the seqno's of the viewport are not being correctly invalidated by the main logic below for the common case. In particular, I'm concerned that if this is needed, it should probably be unconditional rather than scoped to the !allow_scrollback case.
The reason this is conditional is to avoid an additional O(screen-height) fixed overhead for every scroll operation.
Please translate your repro scenario from #6166 into a unit test in
https://github.com/wez/wezterm/blob/main/term/src/test/mod.rs that triggers the problem; I'd like to see what is happening to the seqno's of the lines being scrolled without attempting to fix it, then we can figure out what the right fix is.
There was a problem hiding this comment.
Will do.
Dropped for now and will resubmit.
For enhancement requested in issue wez#6093
As per <rust-lang/rust#123748> ! will no longer degrades into () which in this situation breaks type deduction; so specify it explicitly.
loops
changed the title
|
Thanks! |
Two small separate changes.
Address a compiler warning, and make a small doc change for changes from #6093