Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added custom saga correlation capabilties #211

Closed
wants to merge 5 commits into from
Closed

added custom saga correlation capabilties #211

wants to merge 5 commits into from

Conversation

rhinof
Copy link
Contributor

@rhinof rhinof commented Oct 16, 2019

@rhinof rhinof requested review from vladshub, avigailberger, danielwitz and a user October 16, 2019 13:23
@coveralls
Copy link

coveralls commented Oct 16, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 76.335% when pulling 19fe111 on custom_saga_locator into e7e27a5 on v1.x.

@rhinof
Copy link
Contributor Author

rhinof commented Oct 18, 2019

@vladshub I have updated the solution along the lines of what we discussed

@rhinof
Copy link
Contributor Author

rhinof commented Oct 20, 2019

@vladshub there is a severe defect in this design in which there might be a race condition that is not trivial to solve when there is more than one consumer. I am closing the PR and abandoning this approach and remaining with the current solution of TargetSaga()

@rhinof rhinof closed this Oct 20, 2019
@vladshub vladshub deleted the custom_saga_locator branch October 20, 2019 08:09
@vladshub vladshub mentioned this pull request Oct 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladshub vladshub Awaiting requested review from vladshub

@avigailberger avigailberger Awaiting requested review from avigailberger

@danielwitz danielwitz Awaiting requested review from danielwitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhinof @coveralls