-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the contributing guidelines #34
Conversation
Thank you very much @kapil-agnihotri, I have addressed now all of your comments. I am waiting for your final approval now before merging. |
CONTRIBUTING.md
Outdated
Replace "your-username" with your GitHub username. | ||
|
||
#### Create a branch | ||
Create a new branch to work on your changes using the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on this #34 (comment) comment?
@kapil-agnihotri ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment.
CONTRIBUTING.md
Outdated
If you still did not fork the repository, follow the instructions in [Getting Started](#getting-started). | ||
|
||
#### Create a branch | ||
Create a new branch on your forked directory to work on your changes using the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be forked repository
instead of forked directory.
Add the contributing guidelines and update the readme file.