Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the contributing guidelines #34

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

Flaminietta
Copy link
Collaborator

Add the contributing guidelines and update the readme file.

@Flaminietta Flaminietta self-assigned this Feb 29, 2024
@Flaminietta Flaminietta linked an issue Feb 29, 2024 that may be closed by this pull request
@Flaminietta Flaminietta added code quality quality of the code improved joss review related issues related to the review process for publication labels Mar 7, 2024
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@Flaminietta
Copy link
Collaborator Author

Flaminietta commented Mar 7, 2024

Thank you very much @kapil-agnihotri, I have addressed now all of your comments.

I am waiting for your final approval now before merging.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated
Replace "your-username" with your GitHub username.

#### Create a branch
Create a new branch to work on your changes using the following command:
Copy link
Collaborator

@kapil-agnihotri kapil-agnihotri Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on this #34 (comment) comment?

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Flaminietta
Copy link
Collaborator Author

@kapil-agnihotri ready.

Copy link
Collaborator

@kapil-agnihotri kapil-agnihotri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment.

CONTRIBUTING.md Outdated
If you still did not fork the repository, follow the instructions in [Getting Started](#getting-started).

#### Create a branch
Create a new branch on your forked directory to work on your changes using the following command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be forked repository instead of forked directory.

@Flaminietta Flaminietta merged commit e071d84 into main Mar 13, 2024
3 checks passed
@Flaminietta Flaminietta deleted the add-contribution-guidelines branch March 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality quality of the code improved joss review related issues related to the review process for publication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Contribution Guidelines
3 participants