Theme: Fix placeholder image references #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
Pre-approved upon successful review. This is only a content change. |
EricDunsworth
commented
Dec 2, 2024
Garneauma
requested changes
Dec 4, 2024
Some of GCWeb's code samples from recent years were referencing placeholder images from placeholder.com and placehold.it. But those sites underwent changes in ownership in March 2023 and consequently ceased serving placeholder images. This deals with it by replacing all references to via.placeholder.com and placehold.it with dummyimage.com (and swaps ? characters with & where custom text is specified to fit the latter's URL writing scheme). GCWeb has historically used dummyimage.com and that site still exists to this day. Left the following references to placeholder.com "as-is" in the following WCAG assessments since they're meant to represent specific points in time: * templates/institutional-landing/reports/a11y-1.json * templates/institutional-landing/reports/a11y-2.json
EricDunsworth
force-pushed
the
theme-images-placeholder.com-placehold.it-to-dummyimage.com
branch
from
91af4e5 to
d11e63e
Compare
EricDunsworth
temporarily deployed
to
github-ci
GitHub Actions
Inactive
Garneauma
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of GCWeb's code samples from recent years were referencing placeholder images from placeholder.com and placehold.it. But those sites underwent changes in ownership in March 2023 and consequently ceased serving placeholder images.
This deals with it by replacing all references to via.placeholder.com and placehold.it with dummyimage.com (and swaps ? characters with & where custom text is specified to fit the latter's URL writing scheme).
GCWeb has historically used dummyimage.com and that site still exists to this day.
Left the following references to placeholder.com "as-is" in the following WCAG assessments since they're meant to represent specific points in time: