-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All services: Adding new page template and new utilities #2447
Conversation
3e2481f
to
96573fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete review, just some early comments.
Pre-approved upon successful review and application of all requested changes. |
96573fd
to
fd77a1c
Compare
fd77a1c
to
a663e89
Compare
a663e89
to
9d8b1cd
Compare
9d8b1cd
to
e05d4d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I review and a few change is required, see inline comments.
I only checked the pattern, some fix need to be replicated across the other theme and in French too. I didn't identified all instance. I will check that in a subsequent review.
Note: I carefully reviewed the CSS generated for the padding + margin and it looks good. May be eventually, we should look on providing a working example that show may be not all possibility but at least each aspect of the applied style.
There is a lot of addition in this PR, we will need to be careful to list all of them in our release note. @ouafaaetta head-up
e05d4d9
to
840d59c
Compare
840d59c
to
a167d43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my inline comments, still a few edits. Some are more related to content.
a167d43
to
f89df99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested everything.
Just one thing left and then we will be good to merge.
This is a minor change with all the new utilities added
This is a patch change for the template addition because it is limited to one single page.
f89df99
to
3c8c64e
Compare
bg-light
utility class to add light-grey backgroundnav-links
utility class to style list of navigational linksChanges related to WET-498