Update _base.scss #2444
Merged
Update _base.scss #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christopher-O
temporarily deployed
to
github-ci
GitHub Actions
Inactive
Christopher-O
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
Pre-approved upon review and testing. |
Garneauma
reviewed
Nov 26, 2024
Christopher-O
temporarily deployed
to
github-ci
GitHub Actions
Inactive
|
To do by the WET-BOEW team: contribute to this pull request by updating the API documentation so that it reflects this change. |
Clear and simple explanation of the change/update: Updated input elements to be invisible simply by using opacity: 0 and z-index:2 in order for inputs to be selected by Dragon Naturally Speaking adaptive technology voice reader Added fallback to show focus of checkboxes and radio buttons and selection of radio buttons in Windows high contrast mode. The impact on the sponsored department (CRA) for that change/update: Improved accessibility for users of the adaptive technology or visual mode The impact on the public for that change/update: No change for current use cases, but allows easier selection of radio button and checkboxes using Dragon Naturally Speaking, and provides proper focus in high contrast mode when using keyboard and selecting radio buttons
Garneauma
approved these changes
Nov 27, 2024
SebastianBurke
added a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Nov 27, 2024
Feedback area: adding a11y assessment performed by CRA (wet-boew#2433) Patch - Méli-mélo: DataTable Utilities (wet-boew#2438) * Initial Commit of 2024-10-datatable-utilities * Adjustment to the jeckell html pages as the Javascript Didn't load * Update to the meta.md * Fix to toFrenchMoney Function failing under 'use strict' and Some fixes to the Sample HTML pages * Fix for French Totals coming back as NaN * Implemented wet-boew team Accesibility changes to sample pages + added css to replace <strong> on the Totals * 1.1.0 - Wet-Boew Fixes + French Translation of Examples Page * Fixed a Typo * Added the URL Column to the Raw Data * Updated Implementation Plan * Fixed typo in implementation Plan --------- Co-authored-by: Steve Bourgeois <[email protected]> Patch - GC Home Page: Reduced Doormats and added all services button (wet-boew#2434) * GC Home Page: Reduced Doormats and added all services button * Home: updating All services button styling --------- Co-authored-by: Marc-André Garneau <[email protected]> Patch - Steps Méli-mélo: Update steps.css (wet-boew#2441) * Update steps.css Clear and simple explanation of the change/update: Additional CSS and example added to support basic use (for numbers 2 to 10) of the start attribute for ordered (ol) lists as the CSS design uses a CSS count method to display the numbers and not the generated numbers from the html element. Future design could include a javascript to allow any start number to exist. The impact on the sponsored department (CRA) for that change/update: No impact The impact on the public for that change/update: More flexibility of using the design in various situations. * Update index.html Added extended functionality example for use of start attribute for steps * Update index-fr.html Added extended functionality example using start attribute for steps * Update steps-doc-en.html Added start attribute code * Update steps-doc-fr.html Added code snippet for start attribute * Update meta.md Added updated feature to list * Méli-mélo 2021-05-steps - Add working example for custom starting step * Méli-mélo 2021-05-steps - Typo fix for custom starting steps * Méli-mélo 2021-05-steps - Typo fix for custom starting steps --------- Co-authored-by: Pierre Dubois <[email protected]> Release v15.7.1 (wet-boew#2443) Patch - Update _base.scss (wet-boew#2444) * Update _base.scss Clear and simple explanation of the change/update: Updated input elements to be invisible simply by using opacity: 0 and z-index:2 in order for inputs to be selected by Dragon Naturally Speaking adaptive technology voice reader Added fallback to show focus of checkboxes and radio buttons and selection of radio buttons in Windows high contrast mode. The impact on the sponsored department (CRA) for that change/update: Improved accessibility for users of the adaptive technology or visual mode The impact on the public for that change/update: No change for current use cases, but allows easier selection of radio button and checkboxes using Dragon Naturally Speaking, and provides proper focus in high contrast mode when using keyboard and selecting radio buttons * removed test provisional class extension * adding margin so input is nested inside design * Adding documentation and fixing hidden checkbox hover --------- Co-authored-by: Marc-André Garneau <[email protected]> Requested changes complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear and simple explanation of the change/update:
Updated input elements to be invisible simply by using opacity: 0 and z-index:2 in order for inputs to be selected by Dragon Naturally Speaking adaptive technology voice reader
Added fallback to show focus of checkboxes and radio buttons and selection of radio buttons in Windows high contrast mode.
The impact on the sponsored department (CRA) for that change/update:
Improved accessibility for users of the adaptive technology or visual mode (High contrast)
The impact on the public for that change/update:
No change for current use cases, but allows easier selection of radio button and checkboxes using Dragon Naturally Speaking, and provides proper focus in high contrast mode when using keyboard and selecting radio buttons