Steps quiz - fix content and accessibility issue #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
58f8752
to
2e332ff
Compare
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
2e332ff
to
82c16e0
Compare
|
Pre-approve upon addition of accessibility report and méli-mélo checklist review. |
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
82c16e0
to
d142765
Compare
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
d142765
to
2203800
Compare
@Garneauma changes and additions have been made and pushed to PR. Please review and let me know if it should require any additional changes. |
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
2203800
to
f63b938
Compare
|
@Ricokola Could you please translate the working example page so we can test the French version? |
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
f63b938
to
b441bb2
Compare
duboisp
previously requested changes
Jul 16, 2024
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
b441bb2
to
717a1dc
Compare
|
@Garneauma Changes identified by @duboisp has been made. Note that I have added a |
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
717a1dc
to
c77cb7b
Compare
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
c77cb7b
to
fd5a329
Compare
Ricokola
force-pushed
the
steps-quiz-lang
branch
from
fd5a329
to
6b93720
Compare
Garneauma
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
<progess>must be accompanied or wrapped by a<label>element : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/progress#accessibility.