Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing geo-map #2394

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fixing geo-map #2394

merged 1 commit into from
Jul 17, 2024

Conversation

SebastianBurke
Copy link
Contributor

@SebastianBurke SebastianBurke commented Jul 11, 2024 •
edited
Loading

modified gruntfile.coffee to include geomap's JS files that are excluded in line 839

@SebastianBurke
Copy link
Contributor Author

Abandoned the gruntfile modification and brought over the full demo to gcweb

@Garneauma
Copy link
Contributor

Pre-approved upon successful testing. This is only a content change.

Garneauma
Garneauma requested changes Jul 16, 2024
View reviewed changes
wet-boew/geomap/index.json-ld Outdated Show resolved Hide resolved
Garneauma
Garneauma requested changes Jul 16, 2024
View reviewed changes
wet-boew/geomap/geomap-en.html Outdated Show resolved Hide resolved
Garneauma
Garneauma requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not update geomap-v4.0.30.html (en and fr).

@Garneauma Garneauma merged commit 00a6311 into wet-boew:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garneauma Garneauma Garneauma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianBurke @Garneauma