-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Media Channels - More ways to connect #2391
Conversation
SebastianBurke
commented
Jul 9, 2024
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the link inside the include file instead of the working example page and add a setting in the include file like "if moreWays == true". You can add that setting to the include command in the "more ways to connect" working example.
The "gruntfile.coffee" should not be in this PR. Please revert this change.
You should always git fetch --all
and git reset --hard upstream/master
whenever you start working on a new PR.
Let me know if you have any question. I'll be happy to help.
9770b7b
to
5f8fad7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review.
Please alse update the French working examples. Thanks!
57cc0fd
to
edae680
Compare
91f4683
to
2b95f2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please remove all occurrences of defined parameters defined to false in the include commands.
- Add history item to log this change at line 74 of index.json-ld.
- The inline version with more ways to connect needs to be adjusted. You will need to add a class to this
<li>
likeclass="more-ways"
and some custom styling in_base.scss
. so that it wraps under and does not have the styles of the other elements. I suggest editing line 128 toli:not(.more-ways)
.
3300fc2
to
ce0f412
Compare
8fcc336
to
ec91fd5
Compare
7426270
to
a79b6d2
Compare
a79b6d2
to
4fc00ef
Compare
4fc00ef
to
449377f
Compare
f1741a6
to
0da934e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change. Should be good after that.
718425c
to
a7ac5f0
Compare
Pre-approved upon successful review. Waiting for formal DTO approval. |
@SebastianBurke, DTO just came back and would like for the link to be underlined. Please more the ".more ways" definition to line 105 right under "&:last-child". Please also make sure it reads "&.more-ways". Also, add "text-decoration: underline" to the "a" inside ".more-ways". Thank you. |
f564397
to
843940f
Compare
27a06f8
to
46b791b
Compare
1fe9b31
to
dafa01e
Compare
7d603e2
to
1c1f391
Compare