GC-menu: Labelled for accessibility #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duboisp
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Il serait probablement plus simple si tu change seulement la configuration à la place d'ajouter du texte au milieu de la logique. voir https://github.com/wet-boew/GCWeb/blob/master/sites/gcweb-menu/menu.js#L22-L25
BrahimMahadi
force-pushed
the
gc-menu-label
branch
from
fbc8877
to
095bf85
Compare
duboisp
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Didn't tested locally yet but technically it should work. I will test it locally one the last change is completed.
There is one little typo change and @BrahimMahadi please resolve the conversation/comment when you did address them. Thanks
BrahimMahadi
force-pushed
the
gc-menu-label
branch
from
095bf85
to
05c2df0
Compare
|
Pre-appproved upon review and local testing. |
duboisp
approved these changes
Jun 26, 2024
SebastianBurke
pushed a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated aria-label of the GC-menu to make it accessible according to WCAG standards. This PR is linked to JIRA ticket WET-265.