Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch - Most Requested: fix link word wrapping #2380

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Patch - Most Requested: fix link word wrapping #2380

merged 1 commit into from
Jun 18, 2024

Conversation

Garneauma
Copy link
Contributor

@Garneauma Garneauma commented Jun 7, 2024 •
edited
Loading

Fixes when links are wrapping on two lines.

Before fix:
Screen Shot 2024-06-07 at 3 15 32 PM

After fix:
Screen Shot 2024-06-07 at 3 15 25 PM

Changes related to WET-476

@Garneauma
Copy link
Contributor Author

Pre-approved upon successful review.

Ricokola
Ricokola previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@Ricokola Ricokola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally, it appears as expected.

duboisp
duboisp requested changes Jun 14, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peux-tu ajouter un example, indépendant ou pas, qui montre cette situation particulière.

@Garneauma Garneauma added this to the v15.2.1 milestone Jun 17, 2024
@Garneauma
Copy link
Contributor Author

Garneauma commented Jun 17, 2024 •
edited
Loading

Peux-tu ajouter un example, indépendant ou pas, qui montre cette situation particulière.

Exemple ajouté!

@Garneauma Garneauma requested a review from duboisp June 18, 2024 12:55
duboisp
duboisp approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally,

Do work as expected.

@duboisp duboisp merged commit 39738ea into wet-boew:master Jun 18, 2024
1 check passed
SebastianBurke pushed a commit to SebastianBurke/GCWeb that referenced this pull request Jul 10, 2024
@Garneauma @SebastianBurke
Patch - Most Requested: fix wrapping for long text link (wet-boew#2380)
fd98c78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp duboisp approved these changes

@Ricokola Ricokola Ricokola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v15.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Garneauma @duboisp @Ricokola