Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wet-boew working examples #3 #2362

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Wet-boew working examples #3 #2362

merged 1 commit into from
Aug 9, 2024

Conversation

SebastianBurke
Copy link
Contributor

@SebastianBurke SebastianBurke commented May 16, 2024 •
edited by Garneauma
Loading

Added wet-boew working examples:

Footnotes
Form Validation
Menu
Multimedia
Overlay
Paginate
Prettify
Session-Timeout
Share

duboisp
duboisp previously requested changes May 24, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment •
edited by Garneauma
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Remove the example for the menu and just keep the link to the docs.
  • Submit in a new PR the example for the wet-boew mega menu. (This can be done after you completed the change to this PR)
  • Fix the few content changed that I commented inline.

wet-boew/menu/index.json-ld Outdated Show resolved Hide resolved
wet-boew/multimedia/index.json-ld Show resolved Hide resolved
wet-boew/paginate/index.json-ld Outdated Show resolved Hide resolved
wet-boew/session-timeout/index.json-ld Outdated Show resolved Hide resolved
wet-boew/session-timeout/index.json-ld Outdated Show resolved Hide resolved
wet-boew/share/index.json-ld Outdated Show resolved Hide resolved
@Garneauma Garneauma dismissed duboisp’s stale review August 9, 2024 15:04

Requested changes have been done

@Garneauma Garneauma merged commit a761d37 into wet-boew:master Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garneauma Garneauma Garneauma approved these changes

@duboisp duboisp duboisp left review comments

Assignees

@SebastianBurke SebastianBurke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianBurke @duboisp @Garneauma