Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and-or.css #2343

Merged
merged 14 commits into from
Jun 19, 2024
Merged

Update and-or.css #2343

merged 14 commits into from
Jun 19, 2024

Conversation

Christopher-O
Copy link
Contributor

updated line/border from background-image to border-image in order for line to show up better in high contrast mode.

updated line/border from background-image to border-image in order for line to show up better in high contrast mode.
@duboisp
Copy link
Member

duboisp commented Apr 18, 2024

as discussed,

  • Create a page with the French translation of the working example
  • Produce an accessbility assessment and upload it to the project experimental folder.
  • Seperate the Working example vs the Guidance.
  • Cross-link all the project pages and documents to ensure we can find all the information published via our GCWeb website.

After we will work togeter to move out this experimentation into the stable space in the GCWeb product. Thanks

@Garneauma
Copy link
Contributor

Pre-approved upon successful review and completion of all work items.

@Christopher-O
Copy link
Contributor Author

Waiting for @duboisp for conversion of WCAG accessibility points to HTML,
unsure exactly what this task entails
"Cross-link all the project pages and documents to ensure we can find all the information published via our GCWeb website."
@Garneauma could you please advise?

Added min-height to all side by side items to 3em; to exceed the height of the and/or CSS text and container (::before), as well as adjust for items where there is padding for last child element (e.g. alerts).   This will not effect any current visual look other than may provide a better visual separation (border line) for items with a small amount of content.
@Garneauma Garneauma added this to the v15.2.1 milestone Jun 17, 2024
@duboisp
Copy link
Member

duboisp commented Jun 19, 2024

Comment regarding the adaptive style for the high contrast mode,

@media (prefers-contrast: more) {

I tested that CSS and my testing showed it acceptable in our currently supported browser list.

The supported browser are:

  • Chrome (Desktop and mobile)
  • Safari (Desktop and mobile)
  • Edge (Desktop only)

Here my test result in high contrast mode:


Windows Chrome: work as expected

xs-chrome


Windows Edge: work as expected

Same visual as Windows Chrome


Windows Firefox dev: It is broken, the user can not clearly read the conjunction word "and" and "or" because there is a vertical black bar in the middle

xs


MacOS Big Sur Chrome: Don't work as expected, but the text is readable, the white border gradient only affect the circle around the word, not the word itself.

Screen Shot 2024-06-18 at 9 35 49 PM

MacOS Big Sur Safari: Don't work as expected, but the text is readable, the white border gradient only affect the circle around the word, not the word itself.

Same visual as MacOS Big Sur Chrome


Here what it look like in normal mode

image


méli-mélo/2021-05-conjunction/index.html Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/conjunction-doc-fr.html Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/conjunction-doc-en.html Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Jun 19, 2024

@ouafaaetta as discussed, please submit a request change to the little update required in the accessibility report in JSON-LD. Thanks

@duboisp
Copy link
Member

duboisp commented Jun 19, 2024

Completed the review and local testing, everything look good. There is a few typo change to apply prior to merge.

Note that some additional change would be required, post merge like:

  • Use jekyll front-matter to link the other page language
  • Adding the 2 HTML placeholder page to render the accessibility assessment in an HTML format.
  • Producing the index.json-ld file for documentation by leveraging the documentation provided.

méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-conjunction/a11y-1-conjunction.json Outdated Show resolved Hide resolved
Those are all typos content fixes

Co-authored-by: ouafaaetta <[email protected]>
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and locally tested. Some typos has been also fixed and the implementation plan updated.
This experimental project is now ready for being stabilized in GCWeb. We will perform a full review soon.

@duboisp duboisp dismissed ouafaaetta’s stale review June 19, 2024 17:19

Propose changes was all applied

@duboisp duboisp merged commit 3b597b0 into wet-boew:master Jun 19, 2024
1 check passed
@Christopher-O
Copy link
Contributor Author

Changes in the PR

  • Changed border to appear in high contrast
  • Changed font size of CSS generated text to em value for better scalability between parent font sizes
  • Increased miminum height of side by side pattern to create consistant border above and below CSS text design
  • Updated governance towards stabilization

Impact for department

  • No change from a departmental perspective

Impact for the public

  • Allows border to be shown in high contrast (could require additional adjustment for FF and MacOS browsers)
  • Fixed issue of using design in font sizes other than 20px (GCWeb standard)

SebastianBurke pushed a commit to SebastianBurke/GCWeb that referenced this pull request Jul 10, 2024
…on (wet-boew#2343)

* Update and-or.css

updated line/border from background-image to border-image in order for line to show up better in high contrast mode.

* Update and-or.css

* Update meta.md

* changed page to examples to separate from documentation

* Update index-fr.html to example design along with documentation

* Create conjunction-doc-en.html

* Create conjunction-doc-fr.html

* Add files via upload

* added accessibility checklist link

* Update conjunction-doc-fr.html

* Update and-or.css

Added min-height to all side by side items to 3em; to exceed the height of the and/or CSS text and container (::before), as well as adjust for items where there is padding for last child element (e.g. alerts).   This will not effect any current visual look other than may provide a better visual separation (border line) for items with a small amount of content.

* Apply suggestions from code review

Those are all typos content fixes

Co-authored-by: ouafaaetta <[email protected]>

---------

Co-authored-by: Pierre Dubois <[email protected]>
Co-authored-by: ouafaaetta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants