-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and-or.css #2343
Update and-or.css #2343
Conversation
updated line/border from background-image to border-image in order for line to show up better in high contrast mode.
as discussed,
After we will work togeter to move out this experimentation into the stable space in the GCWeb product. Thanks |
Pre-approved upon successful review and completion of all work items. |
Waiting for @duboisp for conversion of WCAG accessibility points to HTML, |
Added min-height to all side by side items to 3em; to exceed the height of the and/or CSS text and container (::before), as well as adjust for items where there is padding for last child element (e.g. alerts). This will not effect any current visual look other than may provide a better visual separation (border line) for items with a small amount of content.
@ouafaaetta as discussed, please submit a request change to the little update required in the accessibility report in JSON-LD. Thanks |
Completed the review and local testing, everything look good. There is a few typo change to apply prior to merge. Note that some additional change would be required, post merge like:
|
Those are all typos content fixes Co-authored-by: ouafaaetta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and locally tested. Some typos has been also fixed and the implementation plan updated.
This experimental project is now ready for being stabilized in GCWeb. We will perform a full review soon.
Changes in the PR
Impact for department
Impact for the public
|
…on (wet-boew#2343) * Update and-or.css updated line/border from background-image to border-image in order for line to show up better in high contrast mode. * Update and-or.css * Update meta.md * changed page to examples to separate from documentation * Update index-fr.html to example design along with documentation * Create conjunction-doc-en.html * Create conjunction-doc-fr.html * Add files via upload * added accessibility checklist link * Update conjunction-doc-fr.html * Update and-or.css Added min-height to all side by side items to 3em; to exceed the height of the and/or CSS text and container (::before), as well as adjust for items where there is padding for last child element (e.g. alerts). This will not effect any current visual look other than may provide a better visual separation (border line) for items with a small amount of content. * Apply suggestions from code review Those are all typos content fixes Co-authored-by: ouafaaetta <[email protected]> --------- Co-authored-by: Pierre Dubois <[email protected]> Co-authored-by: ouafaaetta <[email protected]>
updated line/border from background-image to border-image in order for line to show up better in high contrast mode.