Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update steps.css #2341

Merged
merged 18 commits into from
Jun 19, 2024
Merged

Update steps.css #2341

merged 18 commits into from
Jun 19, 2024

Conversation

Christopher-O
Copy link
Contributor

-removed style for lead zero in striped,-shrunk min height for list and sub list to remove extra spacing when content is two lines or less

-removed style for lead zero in striped,-shrunk min height for list and sub list to remove extra spacing when content is two lines or less
@duboisp
Copy link
Member

duboisp commented Apr 11, 2024

@Christopher-O prior to merge your change, we will need a little bit more such a revised implementation plan and to have tangible evidence that this experimentation are progressing toward a stable component. That evidence can be user research report, accessibility assessment, ACR, translation, proof that DTO completed (or started to draft) the guidance..... as it was specified in the current implementation plan

I will be there at the office hours to answer are your question.

@duboisp
Copy link
Member

duboisp commented Apr 18, 2024

as discussed,

  • Create a page with the French translation of the working example
  • Produce an accessbility assessment and upload it to the project experimental folder.
  • Seperate the Working example vs the Guidance.
  • Cross-link all the project pages and documents to ensure we can find all the information published via our GCWeb website.

After we will work togeter to move out this experimentation into the stable space in the GCWeb product. Thanks

Update entire page to examples separate from documentation to prepare for stabilization.
@Garneauma
Copy link
Contributor

Pre-approved upon successful review and completion of all work items.

@Christopher-O
Copy link
Contributor Author

Waiting for @duboisp for conversion of WCAG accessibility points to HTML,
unsure exactly what this task entails
"Cross-link all the project pages and documents to ensure we can find all the information published via our GCWeb website."
@Garneauma could you please advise?

@Garneauma Garneauma requested a review from duboisp June 10, 2024 14:55
@Garneauma Garneauma added this to the v15.2.1 milestone Jun 17, 2024
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ouafaaetta please submit your change suggestion for the accessibility report like you did in the other PR. Thanks

I completed the code review with the local testing. There is a few typo which we will apply prior to merge this change.

Note: There is some additional change would be required, but those are not mandatory right now like:

  • Using jekyll front-matter to specify the other page language
  • Adding the 2 HTML placeholder page to render the accessibility assessment in an HTML format.
  • Producing the index.json-ld file for documentation by leveraging the documentation provided.

méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/steps-doc-en.html Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/steps-doc-fr.html Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
méli-mélo/2021-05-steps/a11y-1-steps.json Outdated Show resolved Hide resolved
@duboisp duboisp dismissed ouafaaetta’s stale review June 19, 2024 19:18

Propose changes was all applied

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and locally tested. Some typos has been also fixed and the implementation plan updated.
This experimental project is now ready for being stabilized in GCWeb. We will perform a full review soon.

@duboisp duboisp merged commit 226d131 into wet-boew:master Jun 19, 2024
1 check passed
@Christopher-O
Copy link
Contributor Author

Changes in the PR

  • Reduced excessive spacing for small amount of content
  • Removed background color for default list steps number (except in striped mode) as was not showing up properly in high contrast mode
  • Updated governance towards stabilization

Impact for department

  • No change from a departmental perspective

Impact for the public

  • Created a cleaner look for items using list steps with a smaller amount of content
  • Made the numbers more visible for edge case scenarios of print and high contrast

@Christopher-O
Copy link
Contributor Author

Christopher-O commented Jun 19, 2024

One minor to dos (will create new PR):

  • Fix print issue (some text can be cut off in pattern between pages)

SebastianBurke pushed a commit to SebastianBurke/GCWeb that referenced this pull request Jul 10, 2024
…oew#2341)

* Update steps.css

-removed style for lead zero in striped,-shrunk min height for list and sub list to remove extra spacing when content is two lines or less

* Update steps.css

* Update index.html

Update entire page to examples separate from documentation to prepare for stabilization.

* Update index.html

* Create index-fr.html

* Update index.html

* Create steps-doc-en.html

* Create steps-doc-fr.html

* Update meta.md

* fixed header structure

* fixed additional header structure

* updated header structure

* Add files via upload

* added accessibility json link

* Update steps-doc-fr.html

* Apply suggestions from code review

---------

Co-authored-by: ouafaaetta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants