-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update steps.css #2341
Update steps.css #2341
Conversation
-removed style for lead zero in striped,-shrunk min height for list and sub list to remove extra spacing when content is two lines or less
@Christopher-O prior to merge your change, we will need a little bit more such a revised implementation plan and to have tangible evidence that this experimentation are progressing toward a stable component. That evidence can be user research report, accessibility assessment, ACR, translation, proof that DTO completed (or started to draft) the guidance..... as it was specified in the current implementation plan I will be there at the office hours to answer are your question. |
as discussed,
After we will work togeter to move out this experimentation into the stable space in the GCWeb product. Thanks |
Update entire page to examples separate from documentation to prepare for stabilization.
Pre-approved upon successful review and completion of all work items. |
Waiting for @duboisp for conversion of WCAG accessibility points to HTML, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ouafaaetta please submit your change suggestion for the accessibility report like you did in the other PR. Thanks
I completed the code review with the local testing. There is a few typo which we will apply prior to merge this change.
Note: There is some additional change would be required, but those are not mandatory right now like:
- Using jekyll front-matter to specify the other page language
- Adding the 2 HTML placeholder page to render the accessibility assessment in an HTML format.
- Producing the index.json-ld file for documentation by leveraging the documentation provided.
Co-authored-by: ouafaaetta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and locally tested. Some typos has been also fixed and the implementation plan updated.
This experimental project is now ready for being stabilized in GCWeb. We will perform a full review soon.
Changes in the PR
Impact for department
Impact for the public
|
One minor to dos (will create new PR):
|
…oew#2341) * Update steps.css -removed style for lead zero in striped,-shrunk min height for list and sub list to remove extra spacing when content is two lines or less * Update steps.css * Update index.html Update entire page to examples separate from documentation to prepare for stabilization. * Update index.html * Create index-fr.html * Update index.html * Create steps-doc-en.html * Create steps-doc-fr.html * Update meta.md * fixed header structure * fixed additional header structure * updated header structure * Add files via upload * added accessibility json link * Update steps-doc-fr.html * Apply suggestions from code review --------- Co-authored-by: ouafaaetta <[email protected]>
-removed style for lead zero in striped,-shrunk min height for list and sub list to remove extra spacing when content is two lines or less