Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date modified: Adding documentation #2274

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

Garneauma
Copy link
Contributor

No description provided.

@Garneauma Garneauma changed the title Date modified: Adding date modified site functionality documentation Date modified: Adding documentation Nov 2, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to perform a full review + local testing.

sites/page-details/_base.scss Show resolved Hide resolved
sites/page-details/_base.scss Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Nov 14, 2023

Pre-approved upon local testing + review

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai complété la revue et la mise à l'essaie. Tous est ok sauf 3 petits changements éditique.

sites/date-modified/date-modified-fr.html Outdated Show resolved Hide resolved
sites/date-modified/index.json-ld Outdated Show resolved Hide resolved
sites/date-modified/index.json-ld Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, all good.

This is a patch change

@duboisp duboisp merged commit 21a50d9 into wet-boew:master Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants