Action manager: adding action to select input by default #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duboisp
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Todo:
- A few text suggestion
- Can you also document it in the do-action documentation page ( /components/wb-doaction/doaction-doc-en.html ) because any action defined in the action manager is also available for the do-action plugin.
I tested locally and reviewed the change. Everything look good. This is a minor change for the "Action manager" which impact the plugin "Do action" and "URL mapping".
Garneauma
force-pushed
the
action-manager
branch
from
f5d693a to
6582f7e
Compare
|
Pre-approved upon review and local testing. |
duboisp
previously approved these changes
Dec 12, 2023
|
Note: The merge commit was created during the merge conflict resolution. The only file that was conflicting was "_data/sites.json" which are going to be re-generated by the upcoming release. This PR can be squash and merge once the build is completed. |
duboisp
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding "selectinput" option for the "action" property which selects a value for a
<select>tag or checks a<input type ="radio">or `.Changes related to WET-423