Page details: updating doc to new format #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Garneauma
commented
Sep 27, 2023
Garneauma
commented
- Updating doc to new data-first format
- Minor PFT changes
duboisp
requested changes
Sep 30, 2023
Garneauma
force-pushed
the
page-details
branch
from
0526cf3 to
9b6ea21
Compare
Garneauma
force-pushed
the
page-details
branch
from
9b6ea21 to
a900ff7
Compare
|
Pre-approved upon review + local testing This is only a patch for GCWeb Jekyll, no impact on GCWeb versioning API, only content change for GCWeb. |
Garneauma
force-pushed
the
page-details
branch
from
a900ff7 to
741354a
Compare
duboisp
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Reviewed and tested locally,
Other than the small change, it will be good to merge once completed.
Side note: Regarding the property "assets" in the iteration, we might split it into 2 properties like "Code sample" + "Assets" but let keep that change for later.
Garneauma
force-pushed
the
page-details
branch
from
741354a to
57253c6
Compare
duboisp
requested changes
Oct 31, 2023
Garneauma
force-pushed
the
page-details
branch
from
57253c6 to
7d4f40e
Compare
duboisp
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.