Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content - Feedback - Update documentation #2262

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Content - Feedback - Update documentation #2262

merged 3 commits into from
Sep 29, 2023

Conversation

duboisp
Copy link
Member

@duboisp duboisp commented Sep 26, 2023

  • Apply updates to implementation as discussed with DTO during office hours
  • Improved the code sample displayed in the working example
  • Fix the grunt script to not rely on a generated file when initiating any task
  • Updated the generated content

@duboisp
Content - Feedback - Update documentation
d917ae6 
* Apply updates to implementation as discussed with DTO during office hours
* Improved the code sample displayed in the working example
* Fix the grunt script to not rely on a generated file when initiating any task
* Updated the generated content
@duboisp duboisp requested a review from Garneauma September 26, 2023 22:27
@duboisp duboisp temporarily deployed to github-ci September 26, 2023 22:27 — with GitHub Actions Inactive
@duboisp
Copy link
Member Author

duboisp commented Sep 27, 2023

@LanaStewa FYI

Garneauma
Garneauma requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Garneauma Garneauma left a comment •
edited by duboisp
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
sites/feedback/index.json-ld Outdated Show resolved Hide resolved
@duboisp duboisp temporarily deployed to github-ci September 29, 2023 13:00 — with GitHub Actions Inactive
@duboisp duboisp requested a review from Garneauma September 29, 2023 15:25
@duboisp duboisp temporarily deployed to github-ci September 29, 2023 15:25 — with GitHub Actions Inactive
@Garneauma Garneauma merged commit adfeb5d into wet-boew:master Sep 29, 2023
SebastianBurke added a commit to SebastianBurke/GCWeb that referenced this pull request Nov 7, 2023
@SebastianBurke
Accessibility Project - Pre-assessments
7efcc0f 
WET-380 Ajax Fetch Working Example

Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196)

* Theme: Remove hardcoded post-JS HTML markup
* Remove the following hardcoded markup:
  * wb-init and wb-*-inited classes
  * wb-auto-* IDs
    * Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
  * Pages containing affected code samples
  * Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
* Content - Ajust template with the follow-us include and added example of secondary-menu
* Theme: Update page modified dates with post-JS changes
* Bump initial commit's page modified dates to current date
* Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit

GCWeb - Content - Remove hardcoded post-JS HTML markup,
GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template,
GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example)
GCWeb Jekyll - Minor - Add basic support for content with a secondary menu

---------

Co-authored-by: Pierre Dubois <[email protected]>

Step by step navigation: adding documentation

méli-mélo 2023-09-menu - Initial commit (wet-boew#2247)

Co-authored-by: gjb-pch <[email protected]>

Page feedback: hiding page feedback by default and updating doc>
>

Co-authored-by: Pierre Dubois <[email protected]>

Release v13.8.0

GC Tables: Improve display for empty cells

Méli-mélo - Initial commit for: 2023-09-distance-calculator and 2023-09-collection-sort (wet-boew#2245)

Initial commit of new méli-mélo project

* 2023-09-distance-calculator: Initial commit
* 2023-09-collection-sort: Initial commit

Release v13.9.0

docs: Update guidance links in feedback docs

WET-347

Fonts: fixing font loading

Update campaign-menu.js

Update to set focus on menu item

Feedback: updating doc to add migration from RAP to PFT

Release v13.9.1

Content - Review of a few components metadata (wet-boew#2261)

Reviewed the component title and description for:
* gc-subway
* header-rwd

Content - Review of a few components metadata

Content - Feedback - Update documentation (wet-boew#2262)

* Content - Feedback - Update documentation

* Apply updates to implementation as discussed with DTO during office hours
* Improved the code sample displayed in the working example
* Fix the grunt script to not rely on a generated file when initiating any task
* Updated the generated content

* Content - Feedback - Apply suggestions from code review

Co-authored-by: Garneauma <[email protected]>

* Content - Feedback - Update ajax URL in code sample

---------

Co-authored-by: Garneauma <[email protected]>

WET-410 Created a wet-boew section in GCWeb github

Changes to pre-assesments for components:
language
wb-tabs
gc-topic
gcweb-menu
SebastianBurke added a commit to SebastianBurke/GCWeb that referenced this pull request Nov 7, 2023
@SebastianBurke
# This is a combination of 19 commits.
ce27242 
# This is the 1st commit message:

Accessibility Project - Pre-assessments

# This is the commit message wet-boew#2:

WET-380 Ajax Fetch Working Example

# This is the commit message wet-boew#3:

Content - Follow us, Lowest topic section, HTML cleanup - Code maintenance and fixing/adjusting examples (wet-boew#2196)

* Theme: Remove hardcoded post-JS HTML markup
* Remove the following hardcoded markup:
  * wb-init and wb-*-inited classes
  * wb-auto-* IDs
    * Note: Fixes broken local links caused by duplicate IDs
* Update modified dates of:
  * Pages containing affected code samples
  * Pages that reference updated samples/includes
* Spinoff of wet-boew#2179
* Content - Ajust template with the follow-us include and added example of secondary-menu
* Theme: Update page modified dates with post-JS changes
* Bump initial commit's page modified dates to current date
* Change modified dates in several extra pages that are now using the old follow-us include (components/gc-follow-us/follow.html, _includes/components/gc-follow-us/follow.html) via @duboisp's commit


GCWeb - Content - Remove hardcoded post-JS HTML markup,
GCWeb - Content - Adjusted the follow us component used on various page to match the stable example vs beta template,
GCWeb - Content - Adding working example with secondary navigation (fixing the lowest-topic section example)
GCWeb Jekyll - Minor - Add basic support for content with a secondary menu

---------

Co-authored-by: Pierre Dubois <[email protected]>
# This is the commit message wet-boew#4:

Step by step navigation: adding documentation

# This is the commit message wet-boew#5:

méli-mélo 2023-09-menu - Initial commit (wet-boew#2247)

Co-authored-by: gjb-pch <[email protected]>
# This is the commit message wet-boew#6:

Page feedback: hiding page feedback by default and updating doc>
>

Co-authored-by: Pierre Dubois <[email protected]>

# This is the commit message wet-boew#7:

Release v13.8.0

# This is the commit message wet-boew#8:

GC Tables: Improve display for empty cells

# This is the commit message wet-boew#9:

Méli-mélo - Initial commit for: 2023-09-distance-calculator and 2023-09-collection-sort (wet-boew#2245)

Initial commit of new méli-mélo project

* 2023-09-distance-calculator: Initial commit
* 2023-09-collection-sort: Initial commit
# This is the commit message wet-boew#10:

Release v13.9.0

# This is the commit message wet-boew#11:

docs: Update guidance links in feedback docs

# This is the commit message wet-boew#12:

WET-347

# This is the commit message wet-boew#13:

Fonts: fixing font loading

# This is the commit message wet-boew#14:

Update campaign-menu.js

Update to set focus on menu item
# This is the commit message wet-boew#15:

Feedback: updating doc to add migration from RAP to PFT

# This is the commit message wet-boew#16:

Release v13.9.1

# This is the commit message wet-boew#17:

Content - Review of a few components metadata (wet-boew#2261)

Reviewed the component title and description for:
* gc-subway
* header-rwd

Content - Review of a few components metadata
# This is the commit message wet-boew#18:

Content - Feedback - Update documentation (wet-boew#2262)

* Content - Feedback - Update documentation

* Apply updates to implementation as discussed with DTO during office hours
* Improved the code sample displayed in the working example
* Fix the grunt script to not rely on a generated file when initiating any task
* Updated the generated content

* Content - Feedback - Apply suggestions from code review

Co-authored-by: Garneauma <[email protected]>

* Content - Feedback - Update ajax URL in code sample

---------

Co-authored-by: Garneauma <[email protected]>
# This is the commit message wet-boew#19:

WET-410 Created a wet-boew section in GCWeb github
SebastianBurke pushed a commit to SebastianBurke/GCWeb that referenced this pull request Mar 6, 2024
@duboisp @Garneauma @SebastianBurke
Content - Feedback - Update documentation (wet-boew#2262)
c884df1 
* Content - Feedback - Update documentation

* Apply updates to implementation as discussed with DTO during office hours
* Improved the code sample displayed in the working example
* Fix the grunt script to not rely on a generated file when initiating any task
* Updated the generated content

* Content - Feedback - Apply suggestions from code review

Co-authored-by: Garneauma <[email protected]>

* Content - Feedback - Update ajax URL in code sample

---------

Co-authored-by: Garneauma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garneauma Garneauma Garneauma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duboisp @Garneauma