Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility assessment - gc-featured-link and PFT #2256

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ipaksc
Copy link
Contributor

@ipaksc ipaksc commented Sep 21, 2023

No description provided.

@ipaksc ipaksc temporarily deployed to github-ci September 21, 2023 14:26 — with GitHub Actions Inactive
@duboisp duboisp added the Query: Project item Part of a github project label Sep 27, 2023
@ipaksc ipaksc temporarily deployed to github-ci October 30, 2023 14:05 — with GitHub Actions Inactive
@ipaksc ipaksc force-pushed the master branch 4 times, most recently from 57fe2ac to f3d688e Compare October 30, 2023 16:04
@ipaksc ipaksc temporarily deployed to github-ci October 30, 2023 17:32 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline change request and you will need to remove the merge commit.

sites/feedback/reports/a11y-2-en.html Outdated Show resolved Hide resolved
sites/feedback/reports/a11y-2-fr.html Outdated Show resolved Hide resolved
components/gc-featured-link/reports/a11y-2-en.html Outdated Show resolved Hide resolved
components/gc-featured-link/reports/a11y-1-fr.html Outdated Show resolved Hide resolved
components/gc-featured-link/reports/a11y-1-en.html Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note: There is a merge commit that create conflict and would need to be manually fixed.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to remove/replace those merge commit by a normal commit. It do create conflict when I am trying to git rebase upstream/master. The easiest I think will be to create a new fresh commit by using the github diff.

I am going to do a functional review but it looks good from a content point of view.

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested from a functional content point of view and it is all good and do work as expected.

One little change left and to remove the merge commit.

components/gc-featured-link/reports/a11y-1-en.html Outdated Show resolved Hide resolved
@duboisp duboisp changed the title Accessibility assessment #1 - gc-featured-link Accessibility assessment - gc-featured-link and PFT Dec 12, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editing fix required. You did fixed them but they came back during our rebase/squash process.

components/gc-featured-link/reports/a11y-1-fr.html Outdated Show resolved Hide resolved
components/gc-featured-link/reports/a11y-2-en.html Outdated Show resolved Hide resolved
components/gc-featured-link/reports/a11y-2-fr.html Outdated Show resolved Hide resolved
sites/feedback/reports/a11y-2-en.html Outdated Show resolved Hide resolved
sites/feedback/reports/a11y-2-fr.html Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally

It do work as expected.

I am going to add the link to the report in another PR along with a content sync.

@duboisp duboisp merged commit 364ec16 into wet-boew:master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants