Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WET-410: Created a wet-boew section in GCWeb github #2250

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

ouafaaetta
Copy link
Contributor

wet-boew folder created with two plugins inside as requested (as a start)

unable to run the "grunt" command

Gruntfile.coffee Outdated Show resolved Hide resolved
wet-boew/bgimg/index.json-ld Outdated Show resolved Hide resolved
wet-boew/bgimg/index.json-ld Outdated Show resolved Hide resolved
wet-boew/bgimg/bgimg-en.html Outdated Show resolved Hide resolved
wet-boew/bgimg/bgimg-doc-en.hbs Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in a local jekyll instance and I found a few items. I only commented in English but the French equivalent version might require a similar update.

index-en.md Outdated Show resolved Hide resolved
index-en.md Outdated Show resolved Hide resolved
index-en.md Outdated Show resolved Hide resolved
index-en.md Outdated Show resolved Hide resolved
index-en.md Outdated Show resolved Hide resolved
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 15, 2023 15:36 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 15, 2023 17:03 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 15, 2023 17:11 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 15, 2023 18:13 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 18, 2023 13:26 — with GitHub Actions Inactive
index-fr.md Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Sep 20, 2023

Tel que discuté

Code du fichier généré _data/wet-boew.json
[{
	"@context": {
		"@version": 1.1,
		"dct": "http://purl.org/dc/terms/",
		"title": { "@id": "dct:title", "@container": "@language" },
		"description": { "@id": "dct:description", "@container": "@language" },
		"modified": "dct:modified"
	},
		"title": {
		"en": "Background image",
		"fr": "Image d'arrière plan"
	},
	"description": {
		"en": "Apply a background image from the given URL in parameter or as per the image group (srcset) information.",
		"fr": "Défini une image d'arrière plan pour l'URL passé en paramètre ou tel que spécifier par l'information du group d'image (srcset)."
	},
	"modified": "2023-09-12",
	"componentName": "bgimg",
	"status": "stable",
	"pages": {
		"examples": [
			{
				"title": "Background image",
				"language": "en",
				"type": "general",
				"path": "https://wet-boew.github.io/gcweb-compiled-demos/wetboew-demos/bgimg/bgimg-en.html"
			},
			{
				"title": "Image d'arrière plan",
				"language": "fr",
				"url": "https://wet-boew.github.io/gcweb-compiled-demos/wetboew-demos/bgimg/bgimg-fr.html"
			}
		],
		"docs": [
			{
				"title": "Background image",
				"language": "en",
				"url": "https://wet-boew.github.io/wet-boew/docs/ref/bgimg/bgimg-en.html"
			},
			{
				"title": "Image d'arrière plan",
				"language": "fr",
				"url": "https://wet-boew.github.io/wet-boew/docs/ref/bgimg/bgimg-fr.html"
			}
		]
	}
}
,{
	"@context": {
		"@version": 1.1,
		"dct": "http://purl.org/dc/terms/",
		"title": { "@id": "dct:title", "@container": "@language" },
		"description": { "@id": "dct:description", "@container": "@language" },
		"modified": "dct:modified"
	},
		"title": {
		"en": "Favicon",
		"fr": "Favoricône"
	},
	"description": {
		"en": "This plugin provides the ability to add and update the favicon's on a web page.",
		"fr": "Ce plugiciel offre la possibilité d'ajouter et de mettre à jour les favoricônes d'une page. "
	},
	"modified": "2023-09-12",
	"componentName": "favicon",
	"status": "stable",
	"pages": {
		"examples": [
			{
				"title": "Favicon",
				"language": "en",
				"type": "general",
				"url": "https://wet-boew.github.io/gcweb-compiled-demos/wetboew-demos/favicon/favicon-en.html"
			},
			{
				"title": "Favoricône",
				"language": "fr",
				"url": "https://wet-boew.github.io/gcweb-compiled-demos/wetboew-demos/favicon/favicon-fr.html"
			}
		],
		"docs": [
			{
				"title": "Favicon",
				"language": "en",
				"url": "https://wet-boew.github.io/wet-boew/docs/ref/favicon/favicon-en.html"
			},
			{
				"title": "Favoricône",
				"language": "fr",
				"url": "https://wet-boew.github.io/wet-boew/docs/ref/favicon/favicon-fr.html"
			}
		]
	}
}
]

@ouafaaetta ouafaaetta temporarily deployed to github-ci September 20, 2023 19:36 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 20, 2023 19:41 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 21, 2023 13:33 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 21, 2023 14:53 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 21, 2023 15:32 — with GitHub Actions Inactive
index-en.md Outdated Show resolved Hide resolved
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 21, 2023 20:19 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 21, 2023 21:20 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the jekyll build warning/error that are preventing the wet-boew card to be displayed.
Test also the anchor you added, there is one that are not working as expected.

index-en.md Outdated Show resolved Hide resolved
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 29, 2023 11:47 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci September 29, 2023 20:24 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci October 3, 2023 17:51 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci October 3, 2023 19:01 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta temporarily deployed to github-ci October 4, 2023 17:17 — with GitHub Actions Inactive
@ouafaaetta ouafaaetta requested a review from duboisp October 4, 2023 17:23
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review and tested.

Everything look good.

Thanks @ouafaaetta

@duboisp duboisp marked this pull request as ready for review October 4, 2023 17:46
@duboisp duboisp merged commit 68e3826 into wet-boew:master Oct 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants