WET-378 GC Site search bar working example #2223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duboisp
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Since we have improved how to create those working example page, I would like you to make those little update.
-
Move this include file:
- From: https://github.com/wet-boew/GCWeb/blob/master/sites/headers-includes/sitesearch.html
- To: sites/search/includes/sitesearch.html
-
Add link to the pre-assessment report into the index.json-ld file.
-
Update the code sample to leverage the ajax include or the jekyll server side include.
josephdiab
had a problem deploying
to
github-ci
GitHub Actions
Failure
duboisp
requested changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.