Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WET-389 Pre-assessment for panels #2216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josephdiab
Copy link
Contributor

No description provided.

@josephdiab josephdiab temporarily deployed to github-ci July 26, 2023 14:20 — with GitHub Actions Inactive
@josephdiab josephdiab changed the title Pre-accessibility assessment for panels WET-389 Pre-assessment for panels Aug 3, 2023
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some issue with the index.json-ld + html file, but let fix them later.

For now, see the change requested in the pre-a11y-1.json file.

"earl:TestSubject",
"schema:WebPageElement"
],
"dct:description": "Pre assessment of the Panels component.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you means to provide a description for the object @id: ":subject" and not for @id ":non-text-content_itm1".

If that is the case, that description should be set at line 37 to replace this following text:

     "dct:description": "Describe what is being assessed, like the full page or a component inside that page. Provide a pointer when applicable (earl:pointer)",

"earl:subject": {
"@id": "_:subject",
"dct:references": "https://wet-boew.github.io/wet-boew-styleguide/design/panels-en.html",
"dct:hasPart": [{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the panel has part that could or will be easier if they are assessed separately? If not, please remove this property

"dct:description": "Describe what is being assessed, like the full page or a component inside that page. Provide a pointer when applicable (earl:pointer)",
"earl:pointer": {
"@type": "oa:CssSelector",
"@value": "title, meta, #wb-bc, main"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this selector should be more specific. You only pre-assess the portion the page that is related to the panels.

A test you can do to ensure if the selector are ok, you can run in your browser console the command: document.querySelectorAll( "your css selector " ) and see what HTML element has been returned.

For example:

document.querySelectorAll( ".panel" );

]
}
},
"dct:date": null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This date need to be updated of when you did/perform the pre-assessment

Comment on lines +61 to +41
"acr:involvesExpertise": [
"wbv:acr/topics#aria",
"Javascript"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to help to identify what type of expertise is needed in order to fully assess the component.
If you have found some WAI-ARIA instruction (HTML attribute like: role, aria-*) then "wbv:acr/topics#aria" is needed.
If you have found that component do use Javascript for any interactivity, then "Javascript" is needed.
And you can identify any other specialty you may found needed to perform a full WCAG 2.1 assessment.

@josephdiab josephdiab temporarily deployed to github-ci October 10, 2023 18:52 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: For Review
Development

Successfully merging this pull request may close these issues.

2 participants