WCAG upgrade -- added pre-assesment for breadcrumb #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipaksc
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Hi Shiva, Pierre asked me to review PRs related to accessibility project. Could you please make the following changes.
@duboisp Could you please double check when you have time.
ipaksc
reviewed
Sep 27, 2023
| ], | ||
| "reports": [ | ||
| { | ||
| "title": "Accessibility (Only new SC WCAG 2.1/2.2 Level AA)-English report", |
There was a problem hiding this comment.
Suggested change
| "title": "Accessibility (Only new SC WCAG 2.1/2.2 Level AA)-English report", | |
| "title": "Accessibility assessment #1 - Breadcrumb trail", |
To be consistent with other PRs
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "title": "Accessibility (Only new SC WCAG 2.1/2.2 Level AA)-English report", | ||
| "language": "en", | ||
| "path": "reports/pre-a11y-1-en.hbs" |
There was a problem hiding this comment.
Suggested change
| "path": "reports/pre-a11y-1-en.hbs" | |
| "path": "reports/a11y-1-en.html" |
To be consistent with other PRs
There was a problem hiding this comment.
@hanseller please change the file extension in this index.json-ld file
ipaksc
reviewed
Sep 27, 2023
| "path": "reports/pre-a11y-1-en.hbs" | ||
| }, | ||
| { | ||
| "title": "Accessibility (Only new SC WCAG 2.1/2.2 Level AA)-French report", |
There was a problem hiding this comment.
Suggested change
| "title": "Accessibility (Only new SC WCAG 2.1/2.2 Level AA)-French report", | |
| "title": "Évaluation de l'accessibilité #1 - Fil d'Ariane", |
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "title": "Accessibility (Only new SC WCAG 2.1/2.2 Level AA)-French report", | ||
| "language": "fr", | ||
| "path": "reports/pre-a11y-1-fr.hbs" |
There was a problem hiding this comment.
Suggested change
| "path": "reports/pre-a11y-1-fr.hbs" | |
| "path": "reports/a11y-1-fr.html" |
ipaksc
reviewed
Sep 27, 2023
There was a problem hiding this comment.
To be consistent with other PRs. Could please rename the file to a11y-1-en.html
ipaksc
reviewed
Sep 27, 2023
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| { | |||
| "title": "Accessibility assessment #1 - Breadcrumb", | |||
There was a problem hiding this comment.
Suggested change
| "title": "Accessibility assessment #1 - Breadcrumb", | |
| "title": "Accessibility pre-assessment #1 - Breadcrumb trail", |
since this is pre-assessment
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "title": "Accessibility assessment #1 - Breadcrumb", | ||
| "language": "en", | ||
| "description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2", |
There was a problem hiding this comment.
Suggested change
| "description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2", | |
| "description": "Partial. Pre-evaluation of Success Criteria at Level A and Level AA of WCAG 2.1", |
ipaksc
reviewed
Sep 27, 2023
| "parentdir": "breadcrumb", | ||
| "parentPage": "Breadcrumb", | ||
| "parentPageURL": "breadcrumbs", | ||
| "altLangPage": "pre-a11y-1-fr.html", |
There was a problem hiding this comment.
Suggested change
| "altLangPage": "pre-a11y-1-fr.html", | |
| "altLangPage": "a11y-1-fr.html", |
ipaksc
reviewed
Sep 27, 2023
| "parentPage": "Breadcrumb", | ||
| "parentPageURL": "breadcrumbs", | ||
| "altLangPage": "pre-a11y-1-fr.html", | ||
| "dateModified": "2022-07-19", |
There was a problem hiding this comment.
Suggested change
| "dateModified": "2022-07-19", | |
| "dateModified": "2023-07-19", |
is 2022 or 2023
ipaksc
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Could please rename the file to a11y-1-fr.html
ipaksc
reviewed
Sep 27, 2023
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| { | |||
| "title": "Assessment d'accessibilité #1 - Breadcrumb", | |||
There was a problem hiding this comment.
Suggested change
| "title": "Assessment d'accessibilité #1 - Breadcrumb", | |
| "title": "Pré-assessment de l'accessibilité #1 - Fil d'Ariane", |
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "title": "Assessment d'accessibilité #1 - Breadcrumb", | ||
| "language": "fr", | ||
| "description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2", |
There was a problem hiding this comment.
Suggested change
| "description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2", | |
| "description": "Partielle. Pré-évaluation des critères de succès aux niveaux A et AA du WCAG 2.1", |
ipaksc
reviewed
Sep 27, 2023
| "parentdir": "breadcrumb", | ||
| "parentPage": "Breadcrumb", | ||
| "parentPageURL": "breadcrumbs", | ||
| "altLangPage": "pre-a11y-1-en.html", |
There was a problem hiding this comment.
Suggested change
| "altLangPage": "pre-a11y-1-en.html", | |
| "altLangPage": "a11y-1-en.html", |
ipaksc
reviewed
Sep 27, 2023
| "parentPage": "Breadcrumb", | ||
| "parentPageURL": "breadcrumbs", | ||
| "altLangPage": "pre-a11y-1-en.html", | ||
| "dateModified": "2022-07-19", |
There was a problem hiding this comment.
Suggested change
| "dateModified": "2022-07-19", | |
| "dateModified": "2023-07-19", |
ipaksc
reviewed
Sep 27, 2023
| "description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2", | ||
| "tag": "breadcrumb", | ||
| "parentdir": "breadcrumb", | ||
| "parentPage": "Breadcrumb", |
There was a problem hiding this comment.
Suggested change
| "parentPage": "Breadcrumb", | |
| "parentPage": "Breadcrumb trail", |
ipaksc
reviewed
Sep 27, 2023
| "description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2", | ||
| "tag": "breadcrumb", | ||
| "parentdir": "breadcrumb", | ||
| "parentPage": "Breadcrumb", |
There was a problem hiding this comment.
Suggested change
| "parentPage": "Breadcrumb", | |
| "parentPage": "Fil d'Ariane", |
ipaksc
reviewed
Sep 27, 2023
| "earl:TestSubject", | ||
| "schema:WebPageElement" | ||
| ], | ||
| "dct:description": "Textual identification of the web page element that is being evaluated, like: 'Figure 2, a bar chart'. Provide a pointer when applicable (earl:pointer)", |
There was a problem hiding this comment.
Suggested change
| "dct:description": "Textual identification of the web page element that is being evaluated, like: 'Figure 2, a bar chart'. Provide a pointer when applicable (earl:pointer)", | |
| "dct:description": "The purpose of the breadcrumb trail is to reinforce a visitor’s current location in the Canada.ca", |
I would suggest to change the description
ipaksc
reviewed
Sep 27, 2023
| "earl:subject": { | ||
| "@id": "_:subject", | ||
| "dct:references": "https://wet-boew.github.io/GCWeb/sites/breadcrumbs/breadcrumbs-en.html", | ||
| "dct:hasPart": [ |
There was a problem hiding this comment.
Suggested change
| "dct:hasPart": [ | |
| "dct:hasPart": [ I thik this part can be removed from the report. Please confirm it with @duboisp |
ipaksc
reviewed
Sep 27, 2023
| "dct:references": "https://wet-boew.github.io/GCWeb/sites/breadcrumbs/breadcrumbs-en.html", | ||
| "dct:hasPart": [ | ||
| { | ||
| "@id": "_:non-text-content_itm1", |
There was a problem hiding this comment.
Suggested change
| "@id": "_:non-text-content_itm1", | |
| "@id": "_:non-text-content_itm1", I thik this part can be removed from the report. Please confirm it with @duboisp |
ipaksc
reviewed
Sep 27, 2023
| "dct:description": "Textual identification of the web page element that is being evaluated, like: 'Figure 2, a bar chart'. Provide a pointer when applicable (earl:pointer)", | ||
| "earl:pointer": { | ||
| "@type": "oa:CssSelector", | ||
| "@value": "img" |
There was a problem hiding this comment.
Suggested change
| "@value": "img" | |
| "@value": "#wb-bc" |
ipaksc
reviewed
Sep 27, 2023
| } | ||
| }, | ||
| { | ||
| "@id": "_:video_abc", |
There was a problem hiding this comment.
Suggested change
| "@id": "_:video_abc", | |
| "@id": "_:video_abc", I thik this part can be removed from the report. Please confirm it with @duboisp |
ipaksc
reviewed
Sep 27, 2023
| "dct:description": "Textual identification of the web page element that is being evaluated, like: 'Video ABC (earl:pointer)" | ||
| } | ||
| ], | ||
| "@type": [ |
There was a problem hiding this comment.
Suggested change
| "@type": [ | |
| "@type": [ I thik this part can be removed from the report. Please confirm it with @duboisp |
ipaksc
reviewed
Sep 27, 2023
| ] | ||
| } | ||
| }, | ||
| "dct:date": null, |
There was a problem hiding this comment.
Suggested change
| "dct:date": null, | |
| "dct:date": Put a valid date |
ipaksc
reviewed
Sep 27, 2023
| } | ||
| }, | ||
| "dct:date": null, | ||
| "dct:description": "Analyzing and exploring the subject and produce a pre-evaluation of all WCAG 2.1 SC at level AA.", |
There was a problem hiding this comment.
Suggested change
| "dct:description": "Analyzing and exploring the subject and produce a pre-evaluation of all WCAG 2.1 SC at level AA.", | |
| "dct:description": "Pre-evaluation of all WCAG 2.1 SC at level AA.", |
ipaksc
reviewed
Sep 27, 2023
| }, | ||
| "dct:date": null, | ||
| "dct:description": "Analyzing and exploring the subject and produce a pre-evaluation of all WCAG 2.1 SC at level AA.", | ||
| "acr:involvesExpertise": [ |
There was a problem hiding this comment.
Suggested change
| "acr:involvesExpertise": [ | |
| "acr:involvesExpertise": [ I thik this part can be removed from the report. Please confirm it with @duboisp |
ipaksc
reviewed
Sep 27, 2023
| "earl:outcome": "earl:untested", | ||
| "earl:subject": "_:subject", | ||
| "dct:description": "", | ||
| "earl:mode": "earl:unknownMode", |
There was a problem hiding this comment.
Suggested change
| "earl:mode": "earl:unknownMode", | |
| "earl:mode": "earl:manual", |
Please change earl:unknownMode to earl:manual. We do manual testing.
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "earl:test": "WCAG21:meaningful-sequence", | ||
| "earl:subject": "_:subject", | ||
| "earl:outcome": "earl:inapplicable", |
There was a problem hiding this comment.
Suggested change
| "earl:outcome": "earl:inapplicable", | |
| "earl:outcome": "earl:untested", |
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "earl:test": "WCAG21:sensory-characteristics", | ||
| "earl:subject": "_:subject", | ||
| "earl:outcome": "earl:untested", |
There was a problem hiding this comment.
Suggested change
| "earl:outcome": "earl:untested", | |
| "earl:outcome": "earl:inapplicable", |
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "earl:test": "WCAG21:multiple-ways", | ||
| "earl:subject": "_:subject", | ||
| "earl:outcome": "earl:untested", |
There was a problem hiding this comment.
Suggested change
| "earl:outcome": "earl:untested", | |
| "earl:outcome": "earl:inapplicable", |
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "earl:test": "WCAG21:headings-and-labels", | ||
| "earl:subject": "_:subject", | ||
| "earl:outcome": "earl:inapplicable", |
There was a problem hiding this comment.
Suggested change
| "earl:outcome": "earl:inapplicable", | |
| "earl:outcome": "earl:untested", |
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "earl:test": "WCAG21:on-input", | ||
| "earl:subject": "_:subject", | ||
| "earl:outcome": "earl:untested", |
There was a problem hiding this comment.
Suggested change
| "earl:outcome": "earl:untested", | |
| "earl:outcome": "earl:inapplicable", |
ipaksc
reviewed
Sep 27, 2023
| { | ||
| "earl:test": "WCAG21:status-messages", | ||
| "earl:subject": "_:subject", | ||
| "earl:outcome": "earl:untested", |
There was a problem hiding this comment.
Suggested change
| "earl:outcome": "earl:untested", | |
| "earl:outcome": "earl:inapplicable", |
|
Fixes are in my branch PR2209 |
duboisp
requested changes
Mar 14, 2024
| { | ||
| "title": "Accessibility (Only new SC WCAG 2.1/2.2 Level AA)-English report", | ||
| "language": "en", | ||
| "path": "reports/pre-a11y-1-en.hbs" |
There was a problem hiding this comment.
@hanseller please change the file extension in this index.json-ld file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.