Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wet-372 Conduct WCAG assessment for Skip Links (GCWeb) #2205

Merged
merged 10 commits into from
Mar 15, 2024
Merged

wet-372 Conduct WCAG assessment for Skip Links (GCWeb) #2205

merged 10 commits into from
Mar 15, 2024

Conversation

hongbinyu413
Copy link
Contributor

No description provided.

@hongbinyu413 hongbinyu413 temporarily deployed to github-ci July 17, 2023 13:46 — with GitHub Actions Inactive
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
duboisp
duboisp requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this report in the following folder:
https://github.com/wet-boew/GCWeb/tree/master/sites/skiplinks

And update the index.json-ld (Add a new pages group under report) of the skip-link:

For example on how to proceed, see this example: https://github.com/wet-boew/GCWeb/blob/master/sites/footers/index.json-ld#L135C1-L147

common/skip links/reports/ally-1-en.html Outdated Show resolved Hide resolved
@duboisp duboisp assigned AtlakM and unassigned hongbinyu413 Mar 6, 2024
AtlakM added a commit to AtlakM/GCWeb that referenced this pull request Mar 13, 2024
@AtlakM
changes from wet-boew#2205
fa5d5a2
@AtlakM
Copy link
Contributor

AtlakM commented Mar 13, 2024

See here for updates:
AtlakM@fa5d5a2

duboisp
duboisp requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove merge commit

duboisp
duboisp requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to move into sites folder: https://github.com/wet-boew/GCWeb/tree/master/sites/skiplinks

duboisp
duboisp requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtlakM see the request change

common/skiplinks/index.json-ld Outdated Show resolved Hide resolved
common/skiplinks/index.json-ld Outdated Show resolved Hide resolved
common/skiplinks/reports/ally-1-en.html Outdated Show resolved Hide resolved
common/skiplinks/reports/ally-1-fr.html Outdated Show resolved Hide resolved
duboisp
duboisp requested changes Mar 14, 2024
View reviewed changes
common/skiplinks/skiplinks-en.html Outdated Show resolved Hide resolved
common/skiplinks/skiplinks-fr.html Outdated Show resolved Hide resolved
duboisp
duboisp requested changes Mar 14, 2024
View reviewed changes
common/skiplinks/reports/ally-1-en.html Outdated Show resolved Hide resolved
common/skiplinks/reports/ally-1-fr.html Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Mar 14, 2024 •
edited
Loading

Todo:

  • Move the file in the sites/skip-links folder

@duboisp duboisp assigned duboisp and unassigned AtlakM Mar 14, 2024
duboisp
duboisp approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally, everything is good to go now.

This is a content change

@duboisp duboisp changed the title wet-372 Conduct WCAG pre-assessment for Skip Links (GCWeb) wet-372 Conduct WCAG assessment for Skip Links (GCWeb) Mar 15, 2024
@duboisp duboisp merged commit 5dbcfab into wet-boew:master Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipaksc ipaksc ipaksc left review comments

@AtlakM AtlakM AtlakM left review comments

@duboisp duboisp duboisp approved these changes

Assignees

@duboisp duboisp

Labels
Query: Project item Part of a github project
Projects
WCAG 2024 upgrade
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongbinyu413 @AtlakM @duboisp @ipaksc