Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG Assessment - Tab interface - Wet 369 #2203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hongbinyu413
Copy link
Contributor

No description provided.

@hongbinyu413 hongbinyu413 temporarily deployed to github-ci July 17, 2023 13:45 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The html files to contain the similar issue as the other PR for the toggles.
  • Rename the folder "tab inteface" for the plugin technical name
  • Create the index.json-ld file, similar to what I did for the share this page plugin.

"dct:description": "Accessibility conformance reports of Tabbed Interface",
"earl:pointer": {
"@type": "oa:CssSelector",
"@value": "gc-features"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS selector need to be replaced by the tab-interface CSS selector

@duboisp duboisp changed the title Wet 369 WCAG Assessment - Tab interface - Wet 369 Sep 7, 2023
@hongbinyu413 hongbinyu413 temporarily deployed to github-ci September 8, 2023 12:05 — with GitHub Actions Inactive
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
Copy link
Contributor

@AtlakM AtlakM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@AtlakM AtlakM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css selector needs update

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All those 3 files need to be moved into this folder: /wet-boew/wb-tabs/reports

"dct:description": "Accessibility conformance reports of Tabbed Interface",
"earl:pointer": {
"@type": "oa:CssSelector",
"@value": "tab-interface"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@value": "tab-interface"
"@value": ".wb-tabs"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file for "ally-1.json"

Comment on lines +3 to +13
"title": "Assessment d'accessibilité #1 - Interface à onglets",
"language": "fr",
"description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2",
"tag": "tabs",
"parentdir": "tabs",
"parentPage": "Interface à onglets",
"parentPageURL": "skiplinks",
"altLangPage": "a11y-1-en.html",
"dateModified": "2023-07-06",
"layout": "assessment_wrote_en-fr",
"reportURL": "a11y-1.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Assessment d'accessibilité #1 - Interface à onglets",
"language": "fr",
"description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2",
"tag": "tabs",
"parentdir": "tabs",
"parentPage": "Interface à onglets",
"parentPageURL": "skiplinks",
"altLangPage": "a11y-1-en.html",
"dateModified": "2023-07-06",
"layout": "assessment_wrote_en-fr",
"reportURL": "a11y-1.json"
"title": "Assessment d'accessibilité #1 - Interface à onglets",
"language": "fr",
"description": "Partielle. Évaluation des nouveaux critères de succès aux niveaux A et AA de WCAG 2.1 et WCAG 2.2",
"altLangPage": "ally-1-en.html",
"dateModified": "2023-07-06",
"layout": "assessment_wrote_en-fr",
"reportURL": "ally-1.json"

Comment on lines +3 to +13
"title": "Accessibility assessment #1 - Tabbed Interface",
"language": "en",
"description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2",
"tag": "tabs",
"parentdir": "tabs",
"parentPage": "Tabbed Interface",
"parentPageURL": "Tabs",
"altLangPage": "a11y-1-fr.html",
"dateModified": "2023-07-06",
"layout": "assessment_wrote_en-en",
"reportURL": "pre-a11y-1.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Accessibility assessment #1 - Tabbed Interface",
"language": "en",
"description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2",
"tag": "tabs",
"parentdir": "tabs",
"parentPage": "Tabbed Interface",
"parentPageURL": "Tabs",
"altLangPage": "a11y-1-fr.html",
"dateModified": "2023-07-06",
"layout": "assessment_wrote_en-en",
"reportURL": "pre-a11y-1.json"
"title": "Accessibility assessment #1 - Tabbed Interface",
"language": "en",
"description": "Partial. Evaluation of new Success Criteria at Level A and Level AA of WCAG 2.1 and WCAG 2.2",
"altLangPage": "ally-1-fr.html",
"dateModified": "2023-07-06",
"layout": "assessment_wrote_en-en",
"reportURL": "ally-1.json"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Query: Project item Part of a github project
Projects
Status: For Review
Development

Successfully merging this pull request may close these issues.

3 participants