Conduct WCAG pre-assessment for Share Widget (GCWeb wet-368) #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duboisp
requested changes
Aug 31, 2023
There was a problem hiding this comment.
Rename the folder "share widget" for "share".
So all those files are going to be in the folder: common/share/reports
If you did an assessment and not a pre-assessment, please remove the word "Partielle" and "Partial. " inside the page description
And there is a few change in the HTML page front-matter
Co-authored-by: Pierre Dubois <[email protected]>
Co-authored-by: Pierre Dubois <[email protected]>
Co-authored-by: Pierre Dubois <[email protected]>
Co-authored-by: Pierre Dubois <[email protected]>
Co-authored-by: Pierre Dubois <[email protected]>
duboisp
requested changes
Aug 31, 2023
duboisp
previously approved these changes
Sep 6, 2023
duboisp
approved these changes
Sep 6, 2023
|
I added the index.json-ld file for the share widget. I am going to squash and merge once the CI script is successful. This PR is only a content change. |
SebastianBurke
pushed a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Mar 6, 2024
* Conduct WCAG pre-assessment for Share Widget (GCWeb wet-368) * wet-368 Conduct WCAG pre-assessment for Share Widget (GCWeb) * Update common/share widget/reports/ally-1-en.html * Update common/share widget/reports/ally-1-fr.html * Update common/share widget/reports/ally-1-fr.html * Update common/share widget/reports/ally-1-en.html * Update common/share widget/reports/pre-ally-1.json * wet-368 Conduct WCAG pre-assessment for Share Widget (GCWeb) * Share widget - Add index.json-ld file for the component description --------- Co-authored-by: hongbinyu413 <[email protected]> Co-authored-by: Pierre Dubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.