Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content - Borders - Created example pages #2192

Closed
wants to merge 1 commit into from
Closed

Content - Borders - Created example pages #2192

wants to merge 1 commit into from

Conversation

SebastianBurke
Copy link
Contributor

related to: WET-396

@duboisp duboisp requested a review from GormFrank July 13, 2023 15:50
GormFrank
GormFrank requested changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@GormFrank GormFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @SebastianBurke 🥇

IMPORTANT: All of my requested changes apply to French page as well.

common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-en.html Outdated Show resolved Hide resolved
@SebastianBurke SebastianBurke temporarily deployed to github-ci July 20, 2023 05:23 — with GitHub Actions Inactive
duboisp
duboisp requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue with your commit, you will need to remove the "merge" flag. The simplest will be to recreate the commit and then update your branch.

FYI here the commit details
image

common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-en.html Outdated Show resolved Hide resolved
common/borders/borders-fr.html Outdated Show resolved Hide resolved
@SebastianBurke SebastianBurke temporarily deployed to github-ci August 17, 2023 20:04 — with GitHub Actions Inactive
duboisp
duboisp requested changes Aug 31, 2023
View reviewed changes
common/borders/borders-en.html Outdated Show resolved Hide resolved
@duboisp duboisp added the Query: Project item Part of a github project label Sep 21, 2023
@SebastianBurke SebastianBurke temporarily deployed to github-ci October 25, 2023 19:44 — with GitHub Actions Inactive
@SebastianBurke SebastianBurke deleted the borders branch March 6, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duboisp duboisp Awaiting requested review from duboisp

@GormFrank GormFrank Awaiting requested review from GormFrank

Assignees

@SebastianBurke SebastianBurke

Labels
Query: Project item Part of a github project
Projects
WCAG 2024 upgrade
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastianBurke @duboisp @GormFrank