WCAG upgrade - Create test page for: Button #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duboisp
requested changes
Jun 12, 2023
duboisp
requested changes
Jul 13, 2023
duboisp
requested changes
Jul 13, 2023
duboisp
requested changes
Aug 17, 2023
duboisp
requested changes
Aug 24, 2023
duboisp
requested changes
Aug 30, 2023
There was a problem hiding this comment.
The French page DOM structure should match the English page DOM structure in order to have both language equivalent
For example the following need to be updated for the French page
- Les items dans la section Sur cette page
- Le titre "Utilisation améliorée" doit être enlever et les heading level subséquente ajusté
BrahimMahadi
temporarily deployed
to
github-ci
GitHub Actions
Inactive
duboisp
requested changes
Sep 6, 2023
BrahimMahadi
temporarily deployed
to
github-ci
GitHub Actions
Inactive
duboisp
approved these changes
Sep 7, 2023
SebastianBurke
pushed a commit
to SebastianBurke/GCWeb
that referenced
this pull request
Mar 6, 2024
* WCAG upgrade - Create test page for: Button * Button: Addressed Review Comments * Updated working examples * Addressed Requested Changes * Matched DOM structure between both pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a test page with working examples for the various button styles. More info can be found by referencing WET-361.