Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentification A href VS button #2139

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

crochefort
Copy link
Contributor

PR pour cette issue : fix #2138

La différence es au niveau que c'Est pas des mais <a href avec la classe btn-default.

Il vas falloir corrigé la couleur pour possiblement les autres sortes de bouton

@crochefort crochefort changed the title Crochefort authentification Authentification A href VS button Mar 28, 2023
@duboisp duboisp temporarily deployed to github-ci March 28, 2023 21:31 — with GitHub Actions Inactive
@duboisp
Copy link
Member

duboisp commented Mar 28, 2023

@Garneauma can you generate and post a link to a working example for this PR? Thank you.

@Garneauma
Copy link
Contributor

@duboisp
Copy link
Member

duboisp commented Apr 3, 2023

DTO will take a quick look to ensure it is conform to their guidance.

Here a direct link to the newly added example: https://servicecanada.github.io/wet-boew-demos/gcweb-pr2139/sites/authentication/activeusersession-en.html

Which seems to be/will be used through a CDTS and leverage some icon for the session management.

cc @delisma @catalinaperezn


Todo:

  • (For wet-boew team) Add documentation to the authentication pattern to mention we do support an additional variant.

cc @GormFrank

@catalinaperezn
Copy link

We'll review it this week with the whole group at DTO.

@catalinaperezn
Copy link

Good morning friends. Sorry if I'm not doing this correctly. We are learning how to work together on different platforms. At DTO we reviewed the request and we have some questions we put in a google doc we are sending ... It's a draft but I wanted to share it fast instead of waiting for it to be perfect! We can iterate later... @duboisp @GormFrank @delisma https://docs.google.com/document/d/1C0Ma7aasJ6iKl253nIbGuyO2J1ZOV4wl1az9_Vl15p8/edit?usp=sharing

@duboisp
Copy link
Member

duboisp commented Apr 12, 2023

I would like to mention this change request are coming from the wet-boew community where PP only assisted @crochefort during our office hours to submit this contribution.


Thanks for your input @catalinaperezn For record keeping, I am re-posting the content of your shared google docs here. I would like to suggest, if possible for you and for your team, to keep the conversation here about this change request which can be made by making new comments here or in the related github issue #2138.

Note: I am going to re-post here any progress and any new comments made in the shared google doc when I am made aware of any.

Request for more information on pull request #2139 - Sign out and Username buttons

Context

We need more information to better understand this request. Please explain the context:

  • What problem does it solve?
  • In what situations does it apply?
  • What user research supports this proposed solution?

Alignment/Consistency

This is a major pattern for the GC user experience. To retain user trust, please explain:

  • How does it align with how the major authentication services currently do it? (e.g. CRA MyAccount, Service Canada MSCA)
    • If it’s different, explain why and how/why you feel this approach is better
  • Does this align with the direction that TBS OCIO is heading with their Sign in Canada project?
  • Does this impact other authentication patterns? How?

Initial reactions

  • Concern about the use of the power icon on the sign out button - not sure this makes sense for the action
  • For Principal Publisher: Why did this pattern skip meli-melo steps? We want to try to move together from alpha in Canada.ca design system(meli-melo in GCWeb), to beta (provisional in GCWeb), to stable. It should mean the same in DTO and PP and move in alignment from research to testing, to documentation and implementation.

Demande d’information supplémentaire pour la requête de fusionnement #2139 - Boutons de déconnection et d’usager

Contexte

Nous aurions besoin de plus d'informations pour mieux comprendre cette demande. Veuillez expliquer le contexte plus en détails:

  • Quel est le problème que l’on essaie de résoudre?
  • Dans quelles situations cela s’applique-t-il?
  • Il y a t-il de la recherche qui supporte la solution proposée?

Alignement/Consistance

Ce modèle est très important pour l'expérience utilisateur au sein du gouvernement Canadien. Pour conserver la confiance de l’usager, veuillez expliquer:

  • Comment cela s’aligne-t-il avec la façon dont les principaux services d’authentification le font actuellement?” (ex. MonDossier ARC, Service Canada MDSC)
    • Si c’est différent, expliquez pourquoi et comment/pourquoi vous pensez que cette approche est meilleure.
  • Cela s’aligne-t-il avec la direction que prend le TBS OCIO avec leur projet Sign in Canada?
  • Cela a-t-il un impact sur d’autres modèles d’authentification? Comment?

Premières réactions

  • Préoccupation concernant l’utilisation de l’icône d’alimentation sur le bouton de déconnexion - pas sûr que cela ait du sens pour l’action.
  • Pourquoi ce modèle a-t-il sauté les étapes provisoires et méli-mélo??

@duboisp
Copy link
Member

duboisp commented Apr 17, 2023

Will work on a way to present this demo pattern as a community variant and to find a way to illustrate that there is no official guidance approved that support this variant.

@duboisp
Copy link
Member

duboisp commented May 1, 2023

Tomorrow at the office hours, PP and DTO would discuss on how we can merge this PR without creating false perception of "Official pattern" vs "Community pattern" vs "Trusted pattern" when presenting those working example.

@duboisp duboisp temporarily deployed to github-ci June 14, 2023 05:05 — with GitHub Actions Inactive
@duboisp
Copy link
Member

duboisp commented Jun 14, 2023

@Garneauma lorsque tu auras la chance, est ce que tu pourrais mettre à jour le démo temporaire? merci.

@Garneauma
Copy link
Contributor

@duboisp Done. https://servicecanada.github.io/wet-boew-demos/gcweb-pr2139/index.html

Copy link
Collaborator

@GormFrank GormFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few spelling mistakes

_includes/alert-community-stable.html Outdated Show resolved Hide resolved
_includes/alert-community-stable.html Outdated Show resolved Hide resolved
_includes/alert-community-stable.html Outdated Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Jul 4, 2023

Pre-approved once the change is completed and a second review completed.

@duboisp duboisp force-pushed the crochefort-authentification branch from e926369 to 53a61fe Compare July 6, 2023 13:56
@duboisp duboisp temporarily deployed to github-ci July 6, 2023 13:57 — with GitHub Actions Inactive
@duboisp duboisp force-pushed the crochefort-authentification branch from 53a61fe to 296bf7d Compare July 6, 2023 13:58
@duboisp duboisp temporarily deployed to github-ci July 6, 2023 13:58 — with GitHub Actions Inactive
@duboisp duboisp force-pushed the crochefort-authentification branch from 296bf7d to 7550282 Compare July 6, 2023 13:59
@duboisp duboisp temporarily deployed to github-ci July 6, 2023 14:00 — with GitHub Actions Inactive
@duboisp
Copy link
Member

duboisp commented Jul 6, 2023

I updated the example and GCWeb site config to be able to include comments/concern and to advise, when needed, that the pattern is a community contribution.


@catalinaperezn

Why did this pattern skip meli-melo steps? We want to try to move together from alpha in Canada.ca design system(meli-melo in GCWeb), to beta (provisional in GCWeb), to stable. It should mean the same in DTO and PP and move in alignment from research to testing, to documentation and implementation

That depend, it is not a step process but it depend more on the enterprise readiness of the contribution, its code quality, the completeness of the contribution, our capacity to maintain the contribution as a stable product according to our versioning public API, the impact this could have on published guidance and I might miss other factor.

@duboisp duboisp requested a review from GormFrank July 6, 2023 14:07
Copy link
Collaborator

@GormFrank GormFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid first iteration of the Community stable alert box.

@duboisp duboisp merged commit 0ae57f9 into wet-boew:master Jul 6, 2023
1 check passed
SebastianBurke pushed a commit to SebastianBurke/GCWeb that referenced this pull request Mar 6, 2024
* Update index.json-ld
* Update authentication.html
* Create signedoffuser-en.html
* Create signedoffuser-fr.html
* Authentification - Active session pattern adjustment
* Authentification - Community disclaimer for the active session example

Patch - Authentication - Fix hovering contrast colour when containing a primary styled anchor

---------

Co-authored-by: Pierre Dubois <[email protected]>
Co-authored-by: Pierre Dubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bogue - Le contrast de couleur ne fonctionne pas
5 participants