-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback: implementing Page Feedback Tool #2098
Conversation
5b8ebb5
to
ed8102d
Compare
The demo has been updated as of today. The link remains the same (https://servicecanada.github.io/wet-boew-demos/gcweb-pr2098/index.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment: It will most likely to be the version 6 of the feedback component when we will change the component from provisional to stable. The version 5 is the modified version of the RAP that was launched in August 2023 on Canada.ca. And the version 4 is the current one. It's kind of directly map our iteration incremental number for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I revised everything and now here what is left:
- Add spaces between attribute for the feedback include
- Change the domain name for the form submission to a *.canada.ca sub-domain name
Revised the latest change and only the change to a canada.ca sub-domain for form submission URL need to be applied. |
Once the the form submission URL is updated to the canada.ca sub-domain, we will merge this PR. Its pre-approved. |
We just need to confirm what are going to be the final form submission URL in English and in French cc @GormFrank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
The new PFT are now released as a provisional feature until we got the final approval from the User Acceptance Testing with this latest version.
Changes related to WET-219 and WET-249