Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: implementing Page Feedback Tool #2098

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

Garneauma
Copy link
Contributor

  • Implementing Page feedback tool with JSON Manager
  • Updating Report a problem to use JSON Manager
  • Implementing Iteration feature for variants for both

Changes related to WET-219 and WET-249

@Garneauma
Copy link
Contributor Author

@Garneauma
Copy link
Contributor Author

The demo has been updated as of today. The link remains the same (https://servicecanada.github.io/wet-boew-demos/gcweb-pr2098/index.html).

sites/theme.scss Outdated Show resolved Hide resolved
sites/feedback/ajax/page-feedback-en.html Outdated Show resolved Hide resolved
sites/feedback/page-feedback-contact-en.html Show resolved Hide resolved
sites/feedback/page-feedback-contact-fr.html Show resolved Hide resolved
sites/feedback/page-feedback-contact-fr.html Show resolved Hide resolved
sites/feedback/page-feedback-fr.html Outdated Show resolved Hide resolved
sites/feedback/includes/feedback.html Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: It will most likely to be the version 6 of the feedback component when we will change the component from provisional to stable. The version 5 is the modified version of the RAP that was launched in August 2023 on Canada.ca. And the version 4 is the current one. It's kind of directly map our iteration incremental number for now.

sites/feedback/includes/feedback.html Outdated Show resolved Hide resolved
sites/includes/settings.liquid Outdated Show resolved Hide resolved
@Garneauma Garneauma temporarily deployed to github-ci August 11, 2023 12:53 — with GitHub Actions Inactive
@Garneauma Garneauma temporarily deployed to github-ci August 11, 2023 14:20 — with GitHub Actions Inactive
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revised everything and now here what is left:

  • Add spaces between attribute for the feedback include
  • Change the domain name for the form submission to a *.canada.ca sub-domain name

sites/feedback/includes/feedback.html Outdated Show resolved Hide resolved
@Garneauma Garneauma temporarily deployed to github-ci August 11, 2023 15:47 — with GitHub Actions Inactive
sites/feedback/includes/feedback.html Outdated Show resolved Hide resolved
@Garneauma Garneauma temporarily deployed to github-ci August 11, 2023 17:08 — with GitHub Actions Inactive
@duboisp
Copy link
Member

duboisp commented Aug 11, 2023

Revised the latest change and only the change to a canada.ca sub-domain for form submission URL need to be applied.

@duboisp
Copy link
Member

duboisp commented Aug 14, 2023

Once the the form submission URL is updated to the canada.ca sub-domain, we will merge this PR. Its pre-approved.

@Garneauma Garneauma temporarily deployed to github-ci August 14, 2023 15:31 — with GitHub Actions Inactive
sites/feedback/ajax/page-feedback-en.html Outdated Show resolved Hide resolved
sites/feedback/ajax/page-feedback-fr.html Outdated Show resolved Hide resolved
@Garneauma Garneauma temporarily deployed to github-ci August 15, 2023 12:12 — with GitHub Actions Inactive
@duboisp
Copy link
Member

duboisp commented Aug 15, 2023

We just need to confirm what are going to be the final form submission URL in English and in French

cc @GormFrank

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

The new PFT are now released as a provisional feature until we got the final approval from the User Acceptance Testing with this latest version.

@duboisp duboisp merged commit f15e141 into wet-boew:master Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants