Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #130

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Sep 16, 2024

@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner September 16, 2024 16:41
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 5a91579 to 8f091b8 Compare September 23, 2024 16:41
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 8f091b8 to d7534d9 Compare September 30, 2024 16:41
@jefftriplett
Copy link
Contributor

jefftriplett commented Sep 30, 2024

@joshuadavidthomas we should either drop 3.8 support or add an exclude for your fancy bash script so that Django 5.1 isn't tested with 3.8 or 3.9

Screenshot 2024-09-30 at 1 41 19 PM

@joshuadavidthomas
Copy link
Member

@joshuadavidthomas we should either drop 3.8 support or add an exclude for your fancy bash script so that Django 5.1 isn't tested with 3.8 or 3.9

Screenshot 2024-09-30 at 1 41 19 PM

@jefftriplett IIRC, the main part of that happens in this function in the noxfile.py:

def should_skip(python: str, django: str) -> bool:
"""Return True if the test should be skipped"""
if django == DJMAIN and version(python) < version(DJMAIN_MIN_PY):
# Django main requires Python 3.10+
return True
if django == DJ50 and version(python) < version(PY310):
# Django 5.0 requires Python 3.10+
return True
return False

That generates the matrix which the GHA takes and runs with. So just need to add an exception for 5.1

As far as dropping support, I'm not sure. From a high-level, "I am building a public package for others to use" perspective I like trying to support all the versions of Django that are currently supported (so 4.1, 5.0, and 5.1 at the moment) -- unless I am relying specifically on a feature from a new version.

And with that I like trying to hew close to what Django supports for each version, which does include 3.8 and 3.9 for Django 4.1. Though truthfully, I haven't used 3.8 or 3.9 in who know's how long so maybe that's a fool's errand.

Looking at pypistats.org, there are basically no 3.8 downloads and only a handful of 3.9, at least for the past 30 days.

@jefftriplett
Copy link
Contributor

That generates the matrix which the GHA takes and runs with. So just need to add an exception for 5.1

All good. I fiddled around with nox locally and I missed the 50 call. I might have gotten distracted by using nox[uv] which I'll push post your update.

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.4 → v0.6.8](astral-sh/ruff-pre-commit@v0.6.4...v0.6.8)
- [github.com/abravalheri/validate-pyproject: v0.19 → v0.20.2](abravalheri/validate-pyproject@v0.19...v0.20.2)
@jefftriplett jefftriplett force-pushed the pre-commit-ci-update-config branch from d7534d9 to 8f748bd Compare September 30, 2024 19:45
@jefftriplett jefftriplett merged commit 7679924 into main Sep 30, 2024
24 checks passed
@jefftriplett jefftriplett deleted the pre-commit-ci-update-config branch September 30, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants