Feature/support large dml split #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newborn22
force-pushed
the
feature/support_large_DML_split
branch
from
5085f1c to
c547adf
Compare
newborn22
force-pushed
the
feature/support_large_DML_split
branch
2 times, most recently
from
a69f4dc to
c8dfdc5
Compare
newborn22
force-pushed
the
feature/support_large_DML_split
branch
from
fe0fc26 to
111fb05
Compare
earayu
reviewed
Jan 2, 2024
|
Need more Unit Tests. |
gerayking
reviewed
Jan 4, 2024
newborn22
force-pushed
the
feature/support_large_DML_split
branch
2 times, most recently
from
741e189 to
83e7beb
Compare
earayu
reviewed
Jan 10, 2024
| @@ -193,27 +196,29 @@ func NewTabletServer(name string, config *tabletenv.TabletConfig, topoServer *to | |||
| tsv.branchWatch = NewBranchWatcher(tsv, tsv.config.DB.DbaWithDB()) | |||
|
|
|||
| tsv.onlineDDLExecutor = onlineddl.NewExecutor(tsv, alias, topoServer, tsv.lagThrottler, tabletTypeFunc, tsv.onlineDDLExecutorToggleTableBuffer) | |||
| tsv.dmlJonController = jobcontroller.NewJobController("non_transactional_dml_jobs", tabletTypeFunc, tsv, tsv.lagThrottler) | |||
| } | ||
|
|
||
| // todo，feat 可以增加并发Job数的限制 | ||
| // 调用该函数时外部必须拿tableMutex锁和workingTablesMutex锁 |
There was a problem hiding this comment.
Users should be able to change the 'Job level concurrency'.
Need to add a parameter for it.
| } | ||
| } | ||
|
|
||
| func (jc *JobController) tableGC(ctx context.Context, uuid, tableSchema, batchInfoTable, statusSetTime string) error { |
There was a problem hiding this comment.
You should refer tableGC module.
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
…sed on single table, single int pk Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
…float and string Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
…old,userBatchSize) Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
…kip will not work Signed-off-by: newborn22 <[email protected]>
…bit sql without where clause and with limit or order by clause; Signed-off-by: newborn22 <[email protected]>
…uery after calling setQuery; replace sleep with ticker Signed-off-by: newborn22 <[email protected]>
…n creating batch table Signed-off-by: newborn22 <[email protected]>
…ast node instead of string operations Signed-off-by: newborn22 <[email protected]>
…base operation Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
…eclare unsupported PK type; fix failpolicy bugs Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
newborn22
force-pushed
the
feature/support_large_DML_split
branch
from
a5e3263 to
6dc0252
Compare
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
Signed-off-by: newborn22 <[email protected]>
…written to mysql from RFC3339 to Datetime Signed-off-by: newborn22 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
#403
Checklist