Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: Suppresses unnecessary re-rendering within PageEditor #9629

Merged

Conversation

reiji-h
Copy link
Contributor

@reiji-h reiji-h commented Feb 6, 2025

Summary

  • 編集画面で文字を入力するたびに、Editor 上部と下部のコンポーネントも再レンダリングされてしまっていた
  • 上記 PageEditor.tsx 内の不要な再レンダリングを修正
  • 同時多人数編集時に極端に重くなる問題が解決するかはわからない
  • 少なくとも、今回レンダリングされなくなった箇所にかかるコストは 0 に近い(1ms 未満)
  • ストーリーに記述されていた useEditingUsers が怪しい について、極力 EditingUserList を再レンダリングしないようにはなっている

Task

ScreenShot

紫の部分が再レンダリングされている箇所

修正前

スクリーンショット 2025-02-06 174809

修正後

スクリーンショット 2025-02-06 174604

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 0fa81fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@miya miya requested review from miya and yuki-takei and removed request for miya February 10, 2025 10:07
@yuki-takei yuki-takei changed the title fix: Suppresses unnecessary re-rendering within PageEditor imprv: Suppresses unnecessary re-rendering within PageEditor Feb 10, 2025
mergify bot added a commit that referenced this pull request Feb 10, 2025
@mergify mergify bot merged commit 46fcf8d into master Feb 10, 2025
28 checks passed
@mergify mergify bot deleted the fix/157898-161512-delete-re-rendering-in-page-editor branch February 10, 2025 14:08
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants