Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: Display brand logo when editor mode #9596

Closed
wants to merge 6 commits into from

Conversation

satof3
Copy link
Contributor

@satof3 satof3 commented Jan 29, 2025

Task

https://redmine.weseek.co.jp/issues/160589

Summary

  • エディタモード時に左上にブランドロゴを表示
  • lg以下でサイドバーを開いた時にロゴとAppTitleを表示させるタスクは別ストーリーで対応
  • AppTitle とロゴの見た目を揃えるため、AppTitle.module.scss に記述してあった、.grw-logoのサイズ・パディング設定を SidebarBrandLogo.module.scss に移行

Screenshot

スクリーンショット 2025-01-29 14 47 13 image

@satof3 satof3 requested a review from yuki-takei January 29, 2025 06:15
@satof3 satof3 self-assigned this Jan 29, 2025
Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: 377d295

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

<Link
href="/"
className="grw-editor-logo"
data-testid="btn-brand-logo"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btn-brand-logo のような使われていない値は追加しない

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ブランチ切り直したのでクローズしてPR出し直します

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このコンポーネントに追加するというのはあまりやりたくない。
ロゴ・タイトルの出し分け制御は Sidebar.tsx および AppTitle.tsx にまとめているので、更にロジックが分散するとリーダビリティが落ちる。そちらで対応できないだろうか。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ブランチ切り直したのでクローズしてPR出し直します

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants