-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support: Display brand logo when editor mode #9596
Conversation
|
<Link | ||
href="/" | ||
className="grw-editor-logo" | ||
data-testid="btn-brand-logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btn-brand-logo
のような使われていない値は追加しない
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ブランチ切り直したのでクローズしてPR出し直します
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このコンポーネントに追加するというのはあまりやりたくない。
ロゴ・タイトルの出し分け制御は Sidebar.tsx および AppTitle.tsx にまとめているので、更にロジックが分散するとリーダビリティが落ちる。そちらで対応できないだろうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ブランチ切り直したのでクローズしてPR出し直します
Task
https://redmine.weseek.co.jp/issues/160589
Summary
.grw-logo
のサイズ・パディング設定を SidebarBrandLogo.module.scss に移行Screenshot