Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: API v3 Page update #9053

Merged
merged 7 commits into from
Sep 3, 2024
Merged

fix: API v3 Page update #9053

merged 7 commits into from
Sep 3, 2024

Conversation

maeshinshin
Copy link
Contributor

@maeshinshin maeshinshin commented Aug 28, 2024

task: https://redmine.weseek.co.jp/issues/153149

farai 追記)
失敗していた原因

  • user が所属するグループを取得する部分で、user._id ではなく user.id を使用してしまっている
  • GROWI のアプリからのリクエストだと id メソッドはインスタンスに存在するが、access_token を使った API を直接叩く方法だと、id メソッドが取り除かれる:
    req.user = serializeUserSecurely(user);

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: 06a0962

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

if (pageData.grantedGroups.length > 0) {
pageData.grantedGroups = pageData.grantedGroups.map(group => ({
...group,
_id: newRevision._id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

growi の gui で grant を 5 にしたとき ( group に所属しているときのみ閲覧可 ) のときの pageData.grantedGroups の形に合わせました。

Copy link

reg-suit bot commented Sep 2, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei changed the title fix: api v3 page update fix: API v3 Page update Sep 3, 2024
@yuki-takei yuki-takei merged commit d31ee19 into master Sep 3, 2024
28 of 29 checks passed
@yuki-takei yuki-takei deleted the fix/153127-api-v3-page-update branch September 3, 2024 08:50
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
@yuki-takei yuki-takei changed the title fix: API v3 Page update fix: API v3 Page update Sep 5, 2024
@github-actions github-actions bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants