Only restart nginx when elasticsearch is switched

weprovide · Jun 24, 2024 · 2e653ba · 2e653ba
1 parent 60c94eb
commit 2e653ba
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/cli/ValetPlus/Elasticsearch.php b/cli/ValetPlus/Elasticsearch.php
@@ -122,6 +122,7 @@ public function getCurrentVersion(): ?string
      *
      * @param string $version
      * @param string $tld
+     * @return bool
      */
     public function useVersion($version = self::ES_DEFAULT_VERSION, $tld = 'test')
     {
@@ -139,14 +140,15 @@ public function useVersion($version = self::ES_DEFAULT_VERSION, $tld = 'test')
         if ($version === $currentVersion) {
             info('Already on this version');
 
-            return;
+            return false;
         }
         if ($currentVersion) {
             // Stop current version.
             $this->stop($currentVersion);
         }
 
         $this->install($version, $tld);
+        return true;
     }
 
 

diff --git a/cli/valet.php b/cli/valet.php
@@ -607,10 +607,11 @@
                 throw new RuntimeException(sprintf('Not enough arguments (missing: "mode"). Available modes: %s', implode(', ', $modes)));
             }
 
+            $restart = true;
             switch ($mode) {
                 case 'install':
                 case 'use':
-                    Elasticsearch::useVersion($targetVersion, Configuration::read()['tld']);
+                    $restart = Elasticsearch::useVersion($targetVersion, Configuration::read()['tld']);
 
                     break;
                 case 'on':
@@ -629,8 +630,10 @@
                     break;
             }
 
-            PhpFpm::restart();
-            Nginx::restart();
+            if ($restart) {
+                PhpFpm::restart();
+                Nginx::restart();
+            }
         })
         ->descriptions(
                 'Enable/disable/switch Elasticsearch. ' .