Merge pull request #43 from weni-ai/feature/coverage-and-flake8-ci

Add new steps to ci

.coveragerc

@@ -0,0 +1,13 @@
+[run]
+omit =
+    ./manage.py
+    nexus/*/migrations/*
+    */tests/*
+    */__init__.py
+    Dockerfile
+    */settings.py
+    */apps.py
+
+[report]
+fail_under = 90
+skip_empty = true

.flake8

@@ -0,0 +1,11 @@
+[flake8]
+max-line-length = 119
+ignore = E501,W503,E203
+exclude =
+  ./manage.py
+  weni-script.py
+  weni-script-*.py
+  nexus/staticfiles/*
+
+per-file-ignores =
+  *__init__.py: F401

.github/workflows/ci.yml

@@ -28,5 +28,9 @@ jobs:
           pip install poetry
           poetry config virtualenvs.create false --local
           poetry install
-      - name: Run Tests
-        run: task test
+      - name: Run Django Unittests with Coverage
+        run: coverage run manage.py test --verbosity=2 --noinput
+      - name: Coverage Report
+        run: coverage report
+      - name: Flake8
+        run: flake8 nexus/

nexus/orgs/tests/test_permissions.py

@@ -29,9 +29,6 @@ def test_can_create_intelligence_in_org(self):
 
     def test_can_list_org_intelligences(self):
         self.assertTrue(permissions.can_list_org_intelligences(self.user, self.org))
-
-    def test_can_edit_intelligence_of_org(self):
-        self.assertTrue(permissions.can_edit_intelligence_of_org(self.user, self.org))
 
     def test_can_edit_intelligence_of_org(self):
         self.assertTrue(permissions.can_edit_intelligence_of_org(self.user, self.org))
@@ -44,7 +41,7 @@ def test_can_list_content_bases(self):
 
     def test_can_create_content_bases(self):
         self.assertTrue(permissions.can_create_content_bases(self.user, self.org))
-    
+
     def test_can_add_content_base_file(self):
         self.assertTrue(permissions.can_add_content_base_file(self.user, self.org))
 
@@ -78,9 +75,6 @@ def test_can_create_intelligence_in_org(self):
 
     def test_can_list_org_intelligences(self):
         self.assertTrue(permissions.can_list_org_intelligences(self.user, self.org))
-
-    def test_can_edit_intelligence_of_org(self):
-        self.assertTrue(permissions.can_edit_intelligence_of_org(self.user, self.org))
 
     def test_can_edit_intelligence_of_org(self):
         self.assertTrue(permissions.can_edit_intelligence_of_org(self.user, self.org))
@@ -93,7 +87,7 @@ def test_can_list_content_bases(self):
 
     def test_can_create_content_bases(self):
         self.assertTrue(permissions.can_create_content_bases(self.user, self.org))
-    
+
     def test_can_add_content_base_file(self):
         self.assertTrue(permissions.can_add_content_base_file(self.user, self.org))
 
@@ -127,9 +121,6 @@ def test_cant_create_intelligence_in_org(self):
 
     def test_cant_list_org_intelligences(self):
         self.assertTrue(permissions.can_list_org_intelligences(self.user, self.org))
-
-    def test_cant_edit_intelligence_of_org(self):
-        self.assertFalse(permissions.can_edit_intelligence_of_org(self.user, self.org))
 
     def test_cant_edit_intelligence_of_org(self):
         self.assertFalse(permissions.can_edit_intelligence_of_org(self.user, self.org))
@@ -142,7 +133,7 @@ def test_can_list_content_bases(self):
 
     def test_cant_create_content_bases(self):
         self.assertFalse(permissions.can_create_content_bases(self.user, self.org))
-    
+
     def test_cant_add_content_base_file(self):
         self.assertFalse(permissions.can_add_content_base_file(self.user, self.org))
 
@@ -153,4 +144,4 @@ def test_cant_test_content_base(self):
         self.assertFalse(permissions.can_test_content_base(self.user, self.org))
 
     def test_cant_download_content_base_file(self):
-        self.assertFalse(permissions.can_download_content_base_file(self.user, self.org))
+        self.assertFalse(permissions.can_download_content_base_file(self.user, self.org))

nexus/usecases/__init__.py

@@ -2,4 +2,4 @@
     intelligences,
     orgs,
     users
-)
+)

nexus/usecases/intelligences/__init__.py

@@ -27,4 +27,4 @@
     RetrieveIntelligenceUseCase,
     RetrieveContentBaseUseCase,
     RetrieveContentBaseTextUseCase
-)
+)

nexus/usecases/intelligences/create.py

@@ -62,6 +62,5 @@ def create_contentbasetext(
             text=text,
             content_base=contentbase,
             created_by=user,
-            intelligence=contentbase.intelligence
         )
         return contentbasetext

nexus/usecases/intelligences/tests/intelligence_factory.py

@@ -36,4 +36,3 @@ class Meta:
     created_by = factory.SubFactory(UserFactory)
     content_base = factory.SubFactory(ContentBaseFactory)
     text = factory.Sequence(lambda n: 'test%d' % n)
-    intelligence = factory.SubFactory(IntelligenceFactory)

nexus/usecases/orgs/__init__.py

@@ -1,3 +1,3 @@
 from .get_by_uuid import get_by_uuid
 from .exceptions import OrgDoesNotExists
-from .create_org_auth import CreateOrgAuthUseCase
+from .create_org_auth import CreateOrgAuthUseCase

nexus/usecases/orgs/create_org_auth.py

@@ -16,4 +16,4 @@ def create_org_auth(self, org_uuid: str, user_email: str, role: int):
         user = users.get_by_email(user_email)
         org = orgs.get_by_uuid(org_uuid)
 
-        return _create_org_auth(org, user, role)
+        return _create_org_auth(org, user, role)

nexus/usecases/orgs/tests/test_create_org_auth.py

@@ -16,7 +16,6 @@ def setUp(self):
         self.user = self.org.created_by
         self.usecase = CreateOrgAuthUseCase()
 
-
     def test_create_org_auth_admin(self):
         role: int = 3
         org_auth = self.usecase.create_org_auth(str(self.org.uuid), self.user.email, role)