Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WPS115 for enum attributes #3238 #3240

Merged
merged 8 commits into from
Dec 28, 2024
Merged

Fix WPS115 for enum attributes #3238 #3240

merged 8 commits into from
Dec 28, 2024
+139 −5

Conversation

Tapeline
Copy link
Contributor

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Refs #3238

@codecov Codecov
Copy link

codecov bot commented Dec 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa815eb) to head (52e75f4).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #3240   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          348       348           
  Lines        11493     11517   +24     
  Branches       797       797           
=========================================
+ Hits         11493     11517   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sobolevn
sobolevn reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

tests/test_visitors/test_ast/test_naming/test_class_attributes.py Outdated Show resolved Hide resolved
tests/test_visitors/test_ast/test_naming/test_class_attributes.py Outdated Show resolved Hide resolved
wemake_python_styleguide/logic/naming/enums.py Outdated Show resolved Hide resolved
wemake_python_styleguide/violations/naming.py Outdated Show resolved Hide resolved
wemake_python_styleguide/violations/naming.py Outdated Show resolved Hide resolved
wemake_python_styleguide/visitors/ast/naming/validation.py Outdated Show resolved Hide resolved
wemake_python_styleguide/visitors/ast/naming/validation.py Show resolved Hide resolved
wemake_python_styleguide/visitors/ast/naming/validation.py Outdated Show resolved Hide resolved
wemake_python_styleguide/visitors/ast/naming/validation.py Outdated Show resolved Hide resolved
wemake_python_styleguide/visitors/ast/naming/validation.py Outdated Show resolved Hide resolved
sobolevn
sobolevn reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

CHANGELOG.md Outdated Show resolved Hide resolved
tests/test_visitors/test_ast/test_naming/test_class_attributes.py Show resolved Hide resolved
sobolevn
sobolevn approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn sobolevn merged commit 5e19fcd into wemake-services:master Dec 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tapeline @sobolevn