Set a default healthcheck path based on path pattern (#18)

wellcometrust · Dec 5, 2017 · 547ddfb · 547ddfb
1 parent 90ec1e5
commit 547ddfb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/services/main.tf b/services/main.tf
@@ -1,3 +1,9 @@
+locals {
+  default_healthcheck_path  = "/management/healthcheck"
+  fallback_healthcheck_path = "${replace(var.path_pattern, "/*", local.default_healthcheck_path)}"
+  healthcheck_path          = "${var.healthcheck_path == "" ? local.fallback_healthcheck_path : var.healthcheck_path}"
+}
+
 module "service" {
   source              = "./ecs_service"
   service_name        = "${var.name}"
@@ -11,7 +17,7 @@ module "service" {
   path_pattern        = "${var.path_pattern}"
   alb_priority        = "${var.alb_priority}"
   desired_count       = "${var.desired_count}"
-  healthcheck_path    = "${var.healthcheck_path}"
+  healthcheck_path    = "${local.healthcheck_path}"
   infra_bucket        = "${var.infra_bucket}"
   host_name           = "${var.host_name}"
 

diff --git a/services/variables.tf b/services/variables.tf
@@ -82,8 +82,8 @@ variable "path_pattern" {
 }
 
 variable "healthcheck_path" {
-  description = "path for ECS healthcheck endpoint"
-  default     = "/management/healthcheck"
+  description = "Path for ECS healthcheck endpoint.  Defaults to /management/healthcheck."
+  default     = ""
 }
 
 variable "infra_bucket" {