Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply prettier to the whole project #495

Merged
merged 1 commit into from
Sep 10, 2024
Merged

chore: apply prettier to the whole project #495

merged 1 commit into from
Sep 10, 2024

Conversation

hugoArregui
Copy link
Contributor

No description provided.

Comment on lines +257 to +259
},
[] as typeof layerChain
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create the function before and reference it here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to be in control of my LR CR lately.. I think prettier and other formatters are ugly and step in the way of beautiful code.

I was using TSServer (typescript's default) formater

Copy link
Member

@menduz menduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im ok with merging this as long as it doesn't become a CI check and both VSCode and nvim accept prettier as a default.

I've checked neovim and it works

@hugoArregui hugoArregui merged commit c1fa69f into main Sep 10, 2024
1 check passed
@hugoArregui hugoArregui deleted the prettier branch September 10, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants